big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix potential heap buffer overflow in hdfs.c. Contributed by Igor Chervatyuk.

Browse Source 
(cherry picked from commit 4972e7a246)
This commit is contained in:
Akira Ajisaka 2021-07-22 10:31:32 +09:00
parent 2fda130260
commit 00c382d118
No known key found for this signature in database
GPG Key ID: C1EDBB9CA400FD50
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfs/hdfs.c
View File

@ -956,9 +956,14 @@ struct hdfsStreamBuilder {
struct hdfsStreamBuilder *hdfsStreamBuilderAlloc(hdfsFS fs, struct hdfsStreamBuilder *hdfsStreamBuilderAlloc(hdfsFS fs,
const char *path, int flags) const char *path, int flags)
{ {
int path_len = strlen(path); size_t path_len = strlen(path);
struct hdfsStreamBuilder *bld; struct hdfsStreamBuilder *bld;
// Check for overflow in path_len
if (path_len > SIZE_MAX - sizeof(struct hdfsStreamBuilder)) {
errno = EOVERFLOW;
return NULL;
}
// sizeof(hdfsStreamBuilder->path) includes one byte for the string // sizeof(hdfsStreamBuilder->path) includes one byte for the string
// terminator // terminator
bld = malloc(sizeof(struct hdfsStreamBuilder) + path_len); bld = malloc(sizeof(struct hdfsStreamBuilder) + path_len);