diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java index d1b7024bc9..844b67ce1a 100755 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java @@ -816,7 +816,7 @@ void register(NamespaceInfo nsInfo) throws IOException { // off disk - so update the bpRegistration object from that info DatanodeRegistration newBpRegistration = bpos.createRegistration(); - LOG.info(this + " beginning handshake with NN"); + LOG.info("{} beginning handshake with NN: {}.", this, nnAddr); while (shouldRun()) { try { @@ -826,15 +826,14 @@ void register(NamespaceInfo nsInfo) throws IOException { bpRegistration = newBpRegistration; break; } catch(EOFException e) { // namenode might have just restarted - LOG.info("Problem connecting to server: " + nnAddr + " :" - + e.getLocalizedMessage()); + LOG.info("Problem connecting to server: {} : {}.", nnAddr, e.getLocalizedMessage()); } catch(SocketTimeoutException e) { // namenode is busy - LOG.info("Problem connecting to server: " + nnAddr); + LOG.info("Problem connecting to server: {}.", nnAddr); } catch(RemoteException e) { - LOG.warn("RemoteException in register", e); + LOG.warn("RemoteException in register to server: {}.", nnAddr, e); throw e; } catch(IOException e) { - LOG.warn("Problem connecting to server: " + nnAddr); + LOG.warn("Problem connecting to server: {}.", nnAddr); } // Try again in a second sleepAndLogInterrupts(1000, "connecting to server"); @@ -844,7 +843,7 @@ void register(NamespaceInfo nsInfo) throws IOException { throw new IOException("DN shut down before block pool registered"); } - LOG.info(this + " successfully registered with NN"); + LOG.info("{} successfully registered with NN: {}.", this, nnAddr); bpos.registrationSucceeded(this, bpRegistration); // reset lease id whenever registered to NN. diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeRegister.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeRegister.java index 7c1c27b4dd..772452decc 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeRegister.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDatanodeRegister.java @@ -76,7 +76,7 @@ public void setUp() throws IOException { actor = new BPServiceActor("test", "test", INVALID_ADDR, null, mockBPOS); fakeNsInfo = mock(NamespaceInfo.class); - // Return a a good software version. + // Return a good software version. doReturn(VersionInfo.getVersion()).when(fakeNsInfo).getSoftwareVersion(); // Return a good layout version for now. doReturn(HdfsServerConstants.NAMENODE_LAYOUT_VERSION).when(fakeNsInfo) @@ -144,7 +144,7 @@ public void testDNShutdwonBeforeRegister() throws Exception { DataNode dn = new DataNode(conf, locations, null, null); BPOfferService bpos = new BPOfferService("test_ns", Lists.newArrayList("nn0"), Lists.newArrayList(nnADDR), - Collections.nCopies(1, null), dn); + Collections.nCopies(1, null), dn); DatanodeProtocolClientSideTranslatorPB fakeDnProt = mock(DatanodeProtocolClientSideTranslatorPB.class); when(fakeDnProt.versionRequest()).thenReturn(fakeNsInfo);