big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-15706. HttpFS: Log more information on request failures. (#2515)

Browse Source
This commit is contained in:
Ahmed Hussein 2020-12-03 17:14:40 -06:00 committed by GitHub
parent db73e994ed
commit 07655a7040
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSExceptionProvider.java
View File

@ -70,12 +70,16 @@ public Response toResponse(Throwable throwable) {
status = Response.Status.NOT_FOUND; status = Response.Status.NOT_FOUND;
} else if (throwable instanceof IOException) { } else if (throwable instanceof IOException) {
status = Response.Status.INTERNAL_SERVER_ERROR; status = Response.Status.INTERNAL_SERVER_ERROR;
logErrorFully(status, throwable);
} else if (throwable instanceof UnsupportedOperationException) { } else if (throwable instanceof UnsupportedOperationException) {
status = Response.Status.BAD_REQUEST; status = Response.Status.BAD_REQUEST;
logErrorFully(status, throwable);
} else if (throwable instanceof IllegalArgumentException) { } else if (throwable instanceof IllegalArgumentException) {
status = Response.Status.BAD_REQUEST; status = Response.Status.BAD_REQUEST;
logErrorFully(status, throwable);
} else { } else {
status = Response.Status.INTERNAL_SERVER_ERROR; status = Response.Status.INTERNAL_SERVER_ERROR;
logErrorFully(status, throwable);
} }
return createResponse(status, throwable); return createResponse(status, throwable);
} }
@ -95,4 +99,7 @@ protected void log(Response.Status status, Throwable throwable) {
LOG.warn("[{}:{}] response [{}] {}", method, path, status, message, throwable); LOG.warn("[{}:{}] response [{}] {}", method, path, status, message, throwable);
} }
private void logErrorFully(Response.Status status, Throwable throwable) {
LOG.debug("Failed with {}", status, throwable);
}
} }