big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-8174. Remove confusing comment in Path#isAbsolute() (Contributed by Suresh Srinivas)

Browse Source
This commit is contained in:
Vinayakumar B 2015-05-14 14:17:36 +05:30
parent b2c85db86c
commit 0daa5ada68
2 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -677,6 +677,9 @@ Release 2.8.0 - UNRELEASED
HADOOP-11361. Fix a race condition in MetricsSourceAdapter.updateJmxCache. HADOOP-11361. Fix a race condition in MetricsSourceAdapter.updateJmxCache.
(Brahma Reddy Battula via ozawa) (Brahma Reddy Battula via ozawa)
HADOOP-8174. Remove confusing comment in Path#isAbsolute()
(Suresh Srinivas via vinayakumarb)
Release 2.7.1 - UNRELEASED Release 2.7.1 - UNRELEASED
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

12
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
View File

@ -31,8 +31,7 @@
import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration;
/** Names a file or directory in a {@link FileSystem}. /** Names a file or directory in a {@link FileSystem}.
* Path strings use slash as the directory separator. A path string is * Path strings use slash as the directory separator.
* absolute if it begins with a slash.
*/ */
@Stringable @Stringable
@InterfaceAudience.Public @InterfaceAudience.Public
@ -312,14 +311,7 @@ public boolean isUriPathAbsolute() {
return uri.getPath().startsWith(SEPARATOR, start); return uri.getPath().startsWith(SEPARATOR, start);
} }
/** True if the path component of this URI is absolute. */ /** True if the path is not a relative path and starts with root. */
/**
* There is some ambiguity here. An absolute path is a slash
* relative name without a scheme or an authority.
* So either this method was incorrectly named or its
* implementation is incorrect. This method returns true
* even if there is a scheme and authority.
*/
public boolean isAbsolute() { public boolean isAbsolute() {
return isUriPathAbsolute(); return isUriPathAbsolute();
} }