Revert initial HADOOP-9357 patch.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1464182 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
2d02b7741d
commit
0e9f61addc
@ -604,9 +604,6 @@ Release 2.0.5-beta - UNRELEASED
|
|||||||
HADOOP-9125. LdapGroupsMapping threw CommunicationException after some
|
HADOOP-9125. LdapGroupsMapping threw CommunicationException after some
|
||||||
idle time. (Kai Zheng via atm)
|
idle time. (Kai Zheng via atm)
|
||||||
|
|
||||||
HADOOP-9357. Fallback to default authority if not specified in FileContext.
|
|
||||||
(Andrew Wang via eli)
|
|
||||||
|
|
||||||
Release 2.0.4-alpha - UNRELEASED
|
Release 2.0.4-alpha - UNRELEASED
|
||||||
|
|
||||||
INCOMPATIBLE CHANGES
|
INCOMPATIBLE CHANGES
|
||||||
|
@ -244,33 +244,17 @@ private FileContext(final AbstractFileSystem defFs,
|
|||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Resolve a relative path passed from the user.
|
* Remove relative part - return "absolute":
|
||||||
*
|
* If input is relative path ("foo/bar") add wd: ie "/<workingDir>/foo/bar"
|
||||||
* Relative paths are resolved against the current working directory
|
* A fully qualified uri ("hdfs://nn:p/foo/bar") or a slash-relative path
|
||||||
* (e.g. "foo/bar" becomes "/<workingDir>/foo/bar").
|
|
||||||
* Fully-qualified URIs (e.g. "hdfs://nn:p/foo/bar") and slash-relative paths
|
|
||||||
* ("/foo/bar") are returned unchanged.
|
* ("/foo/bar") are returned unchanged.
|
||||||
*
|
*
|
||||||
* Additionally, we fix malformed URIs that specify a scheme but not an
|
|
||||||
* authority (e.g. "hdfs:///foo/bar"). Per RFC 2395, we remove the scheme
|
|
||||||
* if it matches the default FS, and let the default FS add in the default
|
|
||||||
* scheme and authority later (see {@link #AbstractFileSystem#checkPath}).
|
|
||||||
*
|
|
||||||
* Applications that use FileContext should use #makeQualified() since
|
* Applications that use FileContext should use #makeQualified() since
|
||||||
* they really want a fully-qualified URI.
|
* they really want a fully qualified URI.
|
||||||
* Hence this method is not called makeAbsolute() and
|
* Hence this method is not called makeAbsolute() and
|
||||||
* has been deliberately declared private.
|
* has been deliberately declared private.
|
||||||
*/
|
*/
|
||||||
private Path fixRelativePart(Path p) {
|
private Path fixRelativePart(Path p) {
|
||||||
// Per RFC 2396 5.2, drop schema if there is a scheme but no authority.
|
|
||||||
if (p.hasSchemeAndNoAuthority()) {
|
|
||||||
String scheme = p.toUri().getScheme();
|
|
||||||
if (scheme.equalsIgnoreCase(defaultFS.getUri().getScheme())) {
|
|
||||||
p = new Path(p.toUri().getSchemeSpecificPart());
|
|
||||||
}
|
|
||||||
}
|
|
||||||
// Absolute paths are unchanged. Relative paths are resolved against the
|
|
||||||
// current working directory.
|
|
||||||
if (p.isUriPathAbsolute()) {
|
if (p.isUriPathAbsolute()) {
|
||||||
return p;
|
return p;
|
||||||
} else {
|
} else {
|
||||||
|
@ -256,10 +256,6 @@ public boolean isAbsoluteAndSchemeAuthorityNull() {
|
|||||||
return (isUriPathAbsolute() &&
|
return (isUriPathAbsolute() &&
|
||||||
uri.getScheme() == null && uri.getAuthority() == null);
|
uri.getScheme() == null && uri.getAuthority() == null);
|
||||||
}
|
}
|
||||||
|
|
||||||
public boolean hasSchemeAndNoAuthority() {
|
|
||||||
return uri.getScheme() != null && uri.getAuthority() == null;
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* True if the path component (i.e. directory) of this URI is absolute.
|
* True if the path component (i.e. directory) of this URI is absolute.
|
||||||
|
@ -21,8 +21,6 @@
|
|||||||
import java.io.File;
|
import java.io.File;
|
||||||
import java.io.FileNotFoundException;
|
import java.io.FileNotFoundException;
|
||||||
import java.io.IOException;
|
import java.io.IOException;
|
||||||
import java.net.URI;
|
|
||||||
import java.net.URISyntaxException;
|
|
||||||
import java.util.EnumSet;
|
import java.util.EnumSet;
|
||||||
|
|
||||||
import org.apache.hadoop.HadoopIllegalArgumentException;
|
import org.apache.hadoop.HadoopIllegalArgumentException;
|
||||||
@ -1166,40 +1164,6 @@ public void testUnsupportedSymlink() throws IOException {
|
|||||||
Assert.assertEquals(fc.getFileStatus(file), fc.getFileLinkStatus(file));
|
Assert.assertEquals(fc.getFileStatus(file), fc.getFileLinkStatus(file));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* Test that URIs with a scheme, no authority, and absolute path component
|
|
||||||
* resolve with the authority of the default FS.
|
|
||||||
*/
|
|
||||||
@Test(timeout=30000)
|
|
||||||
public void testAbsolutePathSchemeNoAuthority() throws IOException,
|
|
||||||
URISyntaxException {
|
|
||||||
Path file = getTestRootPath(fc, "test/file");
|
|
||||||
createFile(file);
|
|
||||||
URI uri = file.toUri();
|
|
||||||
URI noAuthorityUri = new URI(uri.getScheme(), null, uri.getPath(),
|
|
||||||
uri.getQuery(), uri.getFragment());
|
|
||||||
Path noAuthority = new Path(noAuthorityUri);
|
|
||||||
Assert.assertEquals(fc.getFileStatus(file), fc.getFileStatus(noAuthority));
|
|
||||||
}
|
|
||||||
|
|
||||||
/**
|
|
||||||
* Test that URIs with a scheme, no authority, and relative path component
|
|
||||||
* resolve with the authority of the default FS.
|
|
||||||
*/
|
|
||||||
@Test(timeout=30000)
|
|
||||||
public void testRelativePathSchemeNoAuthority() throws IOException,
|
|
||||||
URISyntaxException {
|
|
||||||
Path workDir = new Path(getAbsoluteTestRootPath(fc), new Path("test"));
|
|
||||||
fc.setWorkingDirectory(workDir);
|
|
||||||
Path file = new Path(workDir, "file");
|
|
||||||
createFile(file);
|
|
||||||
URI uri = file.toUri();
|
|
||||||
URI noAuthorityUri = new URI(uri.getScheme() + ":file");
|
|
||||||
System.out.println(noAuthorityUri);
|
|
||||||
Path noAuthority = new Path(noAuthorityUri);
|
|
||||||
Assert.assertEquals(fc.getFileStatus(file), fc.getFileStatus(noAuthority));
|
|
||||||
}
|
|
||||||
|
|
||||||
protected void createFile(Path path) throws IOException {
|
protected void createFile(Path path) throws IOException {
|
||||||
FSDataOutputStream out = fc.create(path, EnumSet.of(CREATE),
|
FSDataOutputStream out = fc.create(path, EnumSet.of(CREATE),
|
||||||
|
Loading…
Reference in New Issue
Block a user