big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-13962. Add null check for add-replica pool to avoid lock acquiring. Contributed by Surendra Singh Lilhore.

Browse Source
This commit is contained in:
Yiqun Lin 2018-10-09 10:33:13 +08:00
parent 347ea38581
commit 1043795f7f
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/BlockPoolSlice.java
View File

@ -183,8 +183,10 @@ public int compare(File f1, File f2) {
.setConf(conf)
.setInitialUsed(loadDfsUsed())
.build();
// initialize add replica fork join pool
initializeAddReplicaPool(conf);
if (addReplicaThreadPool == null) {
// initialize add replica fork join pool
initializeAddReplicaPool(conf);
}
// Make the dfs usage to be saved during shutdown.
shutdownHook = new Runnable() {
@Override

2
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/ReplicaMap.java
View File

@ -154,7 +154,7 @@ ReplicaInfo addAndGet(String bpid, ReplicaInfo replicaInfo) {
if (oldReplicaInfo != null) {
return oldReplicaInfo;
} else {
set.add(replicaInfo);
set.addOrReplace(replicaInfo);
}
return replicaInfo;
}