big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-18625. Fix method name of RPC.Builder#setnumReaders (#5301)

Browse Source 
Changes method name of RPC.Builder#setnumReaders to setNumReaders()

The original method is still there, just marked deprecated.
It is the one which should be used when working with older branches.

Contributed by Haiyang Hu
This commit is contained in:
huhaiyang 2023-02-09 21:28:34 +08:00 committed by GitHub
parent d5c046518e
commit 113a9e40cb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
View File

@ -900,12 +900,26 @@ public Builder setNumHandlers(int numHandlers) {
/** /**
* @return Default: -1. * @return Default: -1.
* @param numReaders input numReaders. * @param numReaders input numReaders.
* @deprecated call {@link #setNumReaders(int value)} instead.
*/ */
@Deprecated
public Builder setnumReaders(int numReaders) { public Builder setnumReaders(int numReaders) {
this.numReaders = numReaders; this.numReaders = numReaders;
return this; return this;
} }
/**
* Set the number of reader threads.
*
* @return this builder.
* @param value input numReaders.
* @since HADOOP-18625.
*/
public Builder setNumReaders(int value) {
this.numReaders = value;
return this;
}
/** /**
* @return Default: -1. * @return Default: -1.
* @param queueSizePerHandler * @param queueSizePerHandler

2
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
View File

@ -378,7 +378,7 @@ public void testConfRpc() throws IOException {
assertEquals(confReaders, server.getNumReaders()); assertEquals(confReaders, server.getNumReaders());
server = newServerBuilder(conf) server = newServerBuilder(conf)
.setNumHandlers(1).setnumReaders(3).setQueueSizePerHandler(200) .setNumHandlers(1).setNumReaders(3).setQueueSizePerHandler(200)
.setVerbose(false).build(); .setVerbose(false).build();
assertEquals(3, server.getNumReaders()); assertEquals(3, server.getNumReaders());

2
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
View File

@ -333,7 +333,7 @@ public RouterRpcServer(Configuration conf, Router router,
.setBindAddress(confRpcAddress.getHostName()) .setBindAddress(confRpcAddress.getHostName())
.setPort(confRpcAddress.getPort()) .setPort(confRpcAddress.getPort())
.setNumHandlers(handlerCount) .setNumHandlers(handlerCount)
.setnumReaders(readerCount) .setNumReaders(readerCount)
.setQueueSizePerHandler(handlerQueueSize) .setQueueSizePerHandler(handlerQueueSize)
.setVerbose(false) .setVerbose(false)
.setAlignmentContext(routerStateIdContext) .setAlignmentContext(routerStateIdContext)