HDFS-7242. Code improvement for FSN#checkUnreadableBySuperuser. (Contributed by Yi Liu)

This commit is contained in:
Vinayakumar B 2014-10-17 17:48:20 +05:30
parent cba1f9e389
commit 1c3ff0b7c8
2 changed files with 7 additions and 4 deletions

View File

@ -399,6 +399,9 @@ Release 2.7.0 - UNRELEASED
HDFS-7190. Bad use of Preconditions in startFileInternal().
(Dawson Choong via wheat9)
HDFS-7242. Code improvement for FSN#checkUnreadableBySuperuser.
(Yi Liu via vinayakumarb)
Release 2.6.0 - UNRELEASED
INCOMPATIBLE CHANGES

View File

@ -6412,10 +6412,10 @@ private void checkPathAccess(FSPermissionChecker pc,
private void checkUnreadableBySuperuser(FSPermissionChecker pc,
INode inode, int snapshotId)
throws IOException {
for (XAttr xattr : dir.getXAttrs(inode, snapshotId)) {
if (XAttrHelper.getPrefixName(xattr).
equals(SECURITY_XATTR_UNREADABLE_BY_SUPERUSER)) {
if (pc.isSuperUser()) {
if (pc.isSuperUser()) {
for (XAttr xattr : dir.getXAttrs(inode, snapshotId)) {
if (XAttrHelper.getPrefixName(xattr).
equals(SECURITY_XATTR_UNREADABLE_BY_SUPERUSER)) {
throw new AccessControlException("Access is denied for " +
pc.getUser() + " since the superuser is not allowed to " +
"perform this operation.");