big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-16702. MiniDFSCluster should report cause of exception in assert error (#4680)

Browse Source 
When the MiniDFSClsuter detects that an exception caused an exit, it should include that exception as the cause for the AssertionError that it throws. The current AssertError simply reports the message "Test resulted in an unexpected exit" and provides a stack trace to the location of the check for an exit exception. This patch adds the original exception as the cause of the AssertError.
This commit is contained in:
Steve Vaughan 2022-08-11 16:52:39 -04:00 committed by GitHub
parent 6ca2d3f848
commit 2005582a28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
View File

@ -2159,10 +2159,11 @@ public void shutdown(boolean deleteDfsDir, boolean closeFileSystem) {
LOG.info("Shutting down the Mini HDFS Cluster"); LOG.info("Shutting down the Mini HDFS Cluster");
if (checkExitOnShutdown) { if (checkExitOnShutdown) {
if (ExitUtil.terminateCalled()) { if (ExitUtil.terminateCalled()) {
LOG.error("Test resulted in an unexpected exit", Exception cause = ExitUtil.getFirstExitException();
ExitUtil.getFirstExitException()); LOG.error("Test resulted in an unexpected exit", cause);
ExitUtil.resetFirstExitException(); ExitUtil.resetFirstExitException();
throw new AssertionError("Test resulted in an unexpected exit"); throw new AssertionError("Test resulted in an unexpected exit: " +
cause.toString(), cause);
} }
} }
if (closeFileSystem) { if (closeFileSystem) {