diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java index 9bec147228..af3066ebd1 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/AggregatedLogFormat.java @@ -44,11 +44,8 @@ import java.util.Map.Entry; import java.util.Set; import java.util.regex.Pattern; -import org.apache.commons.io.IOUtils; import org.apache.commons.io.input.BoundedInputStream; import org.apache.commons.io.output.WriterOutputStream; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; import org.apache.commons.math3.util.Pair; import org.apache.hadoop.classification.InterfaceAudience.Private; import org.apache.hadoop.classification.InterfaceAudience.Public; @@ -61,6 +58,7 @@ import org.apache.hadoop.fs.Options; import org.apache.hadoop.fs.Path; import org.apache.hadoop.fs.permission.FsPermission; +import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.io.SecureIOUtils; import org.apache.hadoop.io.Writable; import org.apache.hadoop.io.file.tfile.TFile; @@ -71,7 +69,8 @@ import org.apache.hadoop.yarn.conf.YarnConfiguration; import org.apache.hadoop.yarn.exceptions.YarnRuntimeException; import org.apache.hadoop.yarn.util.Times; - +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Predicate; import com.google.common.collect.Iterables; @@ -81,7 +80,8 @@ @Evolving public class AggregatedLogFormat { - private static final Log LOG = LogFactory.getLog(AggregatedLogFormat.class); + private final static Logger LOG = LoggerFactory.getLogger( + AggregatedLogFormat.class); private static final LogKey APPLICATION_ACL_KEY = new LogKey("APPLICATION_ACL"); private static final LogKey APPLICATION_OWNER_KEY = new LogKey("APPLICATION_OWNER"); private static final LogKey VERSION_KEY = new LogKey("VERSION"); @@ -247,7 +247,7 @@ public void write(DataOutputStream out, Set pendingUploadFiles) in = secureOpenFile(logFile); } catch (IOException e) { logErrorMessage(logFile, e); - IOUtils.closeQuietly(in); + IOUtils.cleanupWithLogger(LOG, in); continue; } @@ -285,7 +285,7 @@ public void write(DataOutputStream out, Set pendingUploadFiles) String message = logErrorMessage(logFile, e); out.write(message.getBytes(Charset.forName("UTF-8"))); } finally { - IOUtils.closeQuietly(in); + IOUtils.cleanupWithLogger(LOG, in); } } } @@ -555,7 +555,7 @@ public void close() { } catch (Exception e) { LOG.warn("Exception closing writer", e); } finally { - IOUtils.closeQuietly(this.fsDataOStream); + IOUtils.cleanupWithLogger(LOG, this.fsDataOStream); } } } @@ -603,7 +603,7 @@ public String getApplicationOwner() throws IOException { } return null; } finally { - IOUtils.closeQuietly(ownerScanner); + IOUtils.cleanupWithLogger(LOG, ownerScanner); } } @@ -649,7 +649,7 @@ public Map getApplicationAcls() } return acls; } finally { - IOUtils.closeQuietly(aclScanner); + IOUtils.cleanupWithLogger(LOG, aclScanner); } } @@ -774,8 +774,7 @@ public static void readAcontainerLogs(DataInputStream valueStream, } } } finally { - IOUtils.closeQuietly(ps); - IOUtils.closeQuietly(os); + IOUtils.cleanupWithLogger(LOG, ps, os); } } @@ -1001,9 +1000,7 @@ public static Pair readContainerMetaDataAndSkipData( } public void close() { - IOUtils.closeQuietly(scanner); - IOUtils.closeQuietly(reader); - IOUtils.closeQuietly(fsDataIStream); + IOUtils.cleanupWithLogger(LOG, scanner, reader, fsDataIStream); } } diff --git a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java index aafdb664b3..39f3dc339f 100644 --- a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java +++ b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java @@ -37,9 +37,6 @@ import java.util.List; import java.util.Map; import java.util.Set; -import org.apache.commons.io.IOUtils; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; import org.apache.hadoop.classification.InterfaceAudience.Private; import org.apache.hadoop.classification.InterfaceStability.Unstable; import org.apache.hadoop.conf.Configuration; @@ -47,6 +44,7 @@ import org.apache.hadoop.fs.FileSystem; import org.apache.hadoop.fs.Path; import org.apache.hadoop.fs.permission.FsPermission; +import org.apache.hadoop.io.IOUtils; import org.apache.hadoop.security.UserGroupInformation; import org.apache.hadoop.yarn.api.records.ApplicationAccessType; import org.apache.hadoop.yarn.api.records.ApplicationId; @@ -56,6 +54,8 @@ import org.apache.hadoop.yarn.logaggregation.LogAggregationUtils; import org.apache.hadoop.yarn.webapp.View.ViewContext; import org.apache.hadoop.yarn.webapp.view.HtmlBlock.Block; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat.LogKey; import org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat.LogValue; import org.apache.hadoop.yarn.logaggregation.ContainerLogMeta; @@ -68,7 +68,7 @@ @Unstable public abstract class LogAggregationFileController { - private static final Log LOG = LogFactory.getLog( + private static final Logger LOG = LoggerFactory.getLogger( LogAggregationFileController.class); /* @@ -193,7 +193,7 @@ protected PrintStream createPrintStream(String localDir, String nodeId, protected void closePrintStream(OutputStream out) { if (out != System.out) { - IOUtils.closeQuietly(out); + IOUtils.cleanupWithLogger(LOG, out); } }