big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-18824. ZKDelegationTokenSecretManager causes ArithmeticException due to improper numRetries value checking (#6052)

Browse Source
This commit is contained in:
ConfX 2023-09-14 18:53:31 -04:00 committed by GitHub
parent dea446419f
commit 23360b3f6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java
View File

@ -222,7 +222,7 @@ public ZKDelegationTokenSecretManager(Configuration conf) {
ZK_DTSM_ZK_CONNECTION_TIMEOUT_DEFAULT) ZK_DTSM_ZK_CONNECTION_TIMEOUT_DEFAULT)
) )
.retryPolicy( .retryPolicy(
new RetryNTimes(numRetries, sessionT / numRetries)); new RetryNTimes(numRetries, numRetries == 0 ? 0 : sessionT / numRetries));
} catch (Exception ex) { } catch (Exception ex) {
throw new RuntimeException("Could not Load ZK acls or auth: " + ex, ex); throw new RuntimeException("Could not Load ZK acls or auth: " + ex, ex);
} }

12
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestZKDelegationTokenSecretManager.java
View File

@ -106,10 +106,22 @@ protected Configuration getSecretConf(String connectString) {
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
@Test @Test
public void testMultiNodeOperations() throws Exception { public void testMultiNodeOperations() throws Exception {
testMultiNodeOperationsImpl(false);
}
@Test
public void testMultiNodeOperationsWithZeroRetry() throws Exception {
testMultiNodeOperationsImpl(true);
}
public void testMultiNodeOperationsImpl(boolean setZeroRetry) throws Exception {
for (int i = 0; i < TEST_RETRIES; i++) { for (int i = 0; i < TEST_RETRIES; i++) {
DelegationTokenManager tm1, tm2 = null; DelegationTokenManager tm1, tm2 = null;
String connectString = zkServer.getConnectString(); String connectString = zkServer.getConnectString();
Configuration conf = getSecretConf(connectString); Configuration conf = getSecretConf(connectString);
if (setZeroRetry) {
conf.setInt(ZKDelegationTokenSecretManager.ZK_DTSM_ZK_NUM_RETRIES, 0);
}
tm1 = new DelegationTokenManager(conf, new Text("bla")); tm1 = new DelegationTokenManager(conf, new Text("bla"));
tm1.init(); tm1.init();
tm2 = new DelegationTokenManager(conf, new Text("bla")); tm2 = new DelegationTokenManager(conf, new Text("bla"));