big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-15835. Erasure coding: Add/remove logs for the better readability/debugging. Contributed by Bhavik Patel.

Browse Source
This commit is contained in:
Takanobu Asanuma 2021-02-19 14:44:58 +09:00
parent 9a298d180d
commit 25af8901a9
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
View File

@ -343,6 +343,7 @@ public synchronized ErasureCodingPolicy addPolicy(
policiesByName.values().toArray(new ErasureCodingPolicyInfo[0]); policiesByName.values().toArray(new ErasureCodingPolicyInfo[0]);
allPersistedPolicies.put(policy.getId(), allPersistedPolicies.put(policy.getId(),
new ErasureCodingPolicyInfo(policy)); new ErasureCodingPolicyInfo(policy));
LOG.info("Added erasure coding policy " + policy);
return policy; return policy;
} }
@ -414,7 +415,7 @@ public synchronized boolean disablePolicy(String name) {
enabledPolicies = enabledPolicies =
enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]); enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]);
info.setState(ErasureCodingPolicyState.DISABLED); info.setState(ErasureCodingPolicyState.DISABLED);
LOG.info("Disable the erasure coding policy " + name); LOG.info("Disabled the erasure coding policy " + name);
allPersistedPolicies.put(info.getPolicy().getId(), allPersistedPolicies.put(info.getPolicy().getId(),
createPolicyInfo(info.getPolicy(), createPolicyInfo(info.getPolicy(),
ErasureCodingPolicyState.DISABLED)); ErasureCodingPolicyState.DISABLED));
@ -448,7 +449,7 @@ public synchronized boolean enablePolicy(String name) {
enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]); enabledPoliciesByName.values().toArray(new ErasureCodingPolicy[0]);
allPersistedPolicies.put(ecPolicy.getId(), allPersistedPolicies.put(ecPolicy.getId(),
createPolicyInfo(info.getPolicy(), ErasureCodingPolicyState.ENABLED)); createPolicyInfo(info.getPolicy(), ErasureCodingPolicyState.ENABLED));
LOG.info("Enable the erasure coding policy " + name); LOG.info("Enabled the erasure coding policy " + name);
return true; return true;
} }

1
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
View File

@ -8226,7 +8226,6 @@ boolean disableErasureCodingPolicy(String ecPolicyName,
checkOperation(OperationCategory.WRITE); checkOperation(OperationCategory.WRITE);
checkErasureCodingSupported(operationName); checkErasureCodingSupported(operationName);
boolean success = false; boolean success = false;
LOG.info("Disable the erasure coding policy " + ecPolicyName);
try { try {
writeLock(); writeLock();
try { try {

5
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
View File

@ -2258,10 +2258,10 @@ public void setErasureCodingPolicy(String src, String ecPolicyName)
try { try {
if (ecPolicyName == null) { if (ecPolicyName == null) {
ecPolicyName = defaultECPolicyName; ecPolicyName = defaultECPolicyName;
LOG.trace("No policy name is specified, " + LOG.debug("No policy name is specified, " +
"set the default policy name instead"); "set the default policy name instead");
} }
LOG.trace("Set erasure coding policy " + ecPolicyName + " on " + src); LOG.debug("Set erasure coding policy {} on {}", ecPolicyName, src);
namesystem.setErasureCodingPolicy(src, ecPolicyName, cacheEntry != null); namesystem.setErasureCodingPolicy(src, ecPolicyName, cacheEntry != null);
success = true; success = true;
} finally { } finally {
@ -2491,6 +2491,7 @@ public void unsetErasureCodingPolicy(String src) throws IOException {
} }
boolean success = false; boolean success = false;
try { try {
LOG.debug("Unset erasure coding policy on {}", src);
namesystem.unsetErasureCodingPolicy(src, cacheEntry != null); namesystem.unsetErasureCodingPolicy(src, cacheEntry != null);
success = true; success = true;
} finally { } finally {