HADOOP-16674. Fix when TestDNS.testRDNS can fail with ServiceUnavailableException (#4802). Contributed by Ashutosh Gupta.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
This commit is contained in:
Ashutosh Gupta 2022-09-20 18:39:59 +01:00 committed by GitHub
parent fd687bb4c4
commit 2950c5405b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -25,10 +25,12 @@
import javax.naming.CommunicationException; import javax.naming.CommunicationException;
import javax.naming.NameNotFoundException; import javax.naming.NameNotFoundException;
import javax.naming.ServiceUnavailableException;
import org.apache.hadoop.util.Time; import org.apache.hadoop.util.Time;
import org.assertj.core.api.Assertions; import org.assertj.core.api.Assertions;
import org.junit.Assume;
import org.junit.Test; import org.junit.Test;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -167,7 +169,7 @@ public void testRDNS() throws Exception {
try { try {
String s = DNS.reverseDns(localhost, null); String s = DNS.reverseDns(localhost, null);
LOG.info("Local reverse DNS hostname is " + s); LOG.info("Local reverse DNS hostname is " + s);
} catch (NameNotFoundException | CommunicationException e) { } catch (NameNotFoundException | CommunicationException | ServiceUnavailableException e) {
if (!localhost.isLinkLocalAddress() || localhost.isLoopbackAddress()) { if (!localhost.isLinkLocalAddress() || localhost.isLoopbackAddress()) {
//these addresses probably won't work with rDNS anyway, unless someone //these addresses probably won't work with rDNS anyway, unless someone
//has unusual entries in their DNS server mapping 1.0.0.127 to localhost //has unusual entries in their DNS server mapping 1.0.0.127 to localhost
@ -176,6 +178,7 @@ public void testRDNS() throws Exception {
+ " Loopback=" + localhost.isLoopbackAddress() + " Loopback=" + localhost.isLoopbackAddress()
+ " Linklocal=" + localhost.isLinkLocalAddress()); + " Linklocal=" + localhost.isLinkLocalAddress());
} }
Assume.assumeNoException(e);
} }
} }