big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-16181. [SBN Read] Fix display of JournalNode metric RpcRequestCacheMissAmount (#3317)

Browse Source 
Co-authored-by: wangzhaohui8 <wangzhaohui8@jd.com>

(cherry picked from commit 232fd7cae170de8c6b52c14841a47dca8735c6d2)
This commit is contained in:
wangzhaohui 2021-09-16 00:56:51 +08:00 committed by Erik Krogen
parent b9715c2931
commit 2f73ac1c14
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java
View File

@ -773,7 +773,7 @@ public GetJournaledEditsResponseProto getJournaledEdits(long sinceTxId,
.setEditLog(output.toByteString()) .setEditLog(output.toByteString())
.build(); .build();
} catch (JournaledEditsCache.CacheMissException cme) { } catch (JournaledEditsCache.CacheMissException cme) {
metrics.rpcRequestCacheMissAmount.add(cme.getCacheMissAmount()); metrics.addRpcRequestCacheMissAmount(cme.getCacheMissAmount());
throw cme; throw cme;
} }
} }

16
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
View File

@ -51,12 +51,7 @@ class JournalMetrics {
@Metric("Number of bytes served via RPC") @Metric("Number of bytes served via RPC")
MutableCounterLong bytesServedViaRpc; MutableCounterLong bytesServedViaRpc;
@Metric private MutableStat rpcRequestCacheMissAmount;
MutableStat rpcRequestCacheMissAmount = new MutableStat(
"RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
"served due to lack of availability in cache, and how many " +
"transactions away the request was from being in the cache.",
"Misses", "Txns");
@Metric("Number of RPC requests with zero edits returned") @Metric("Number of RPC requests with zero edits returned")
MutableCounterLong rpcEmptyResponses; MutableCounterLong rpcEmptyResponses;
@ -87,6 +82,11 @@ class JournalMetrics {
"syncs" + interval + "s", "syncs" + interval + "s",
"Journal sync time", "ops", "latencyMicros", interval); "Journal sync time", "ops", "latencyMicros", interval);
} }
rpcRequestCacheMissAmount = registry
.newStat("RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
"served due to lack of availability in cache, and how many " +
"transactions away the request was from being in the cache.",
"Misses", "Txns");
} }
public static JournalMetrics create(Journal j) { public static JournalMetrics create(Journal j) {
@ -149,4 +149,8 @@ public MutableCounterLong getNumEditLogsSynced() {
public void incrNumEditLogsSynced() { public void incrNumEditLogsSynced() {
numEditLogsSynced.incr(); numEditLogsSynced.incr();
} }
public void addRpcRequestCacheMissAmount(long cacheMissAmount) {
rpcRequestCacheMissAmount.add(cacheMissAmount);
}
} }