big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-11494. Lock acquisition on WrappedInputStream#unwrappedRpcBuffer may race with another thread. Contributed by Ted Yu.

Browse Source
This commit is contained in:
Benoy Antony 2015-02-02 10:34:47 -08:00
parent ffc75d6ebe
commit 3472e3bd6c
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslRpcClient.java
View File

@ -573,8 +573,7 @@ public int read(byte b[]) throws IOException {
} }
@Override @Override
public int read(byte[] buf, int off, int len) throws IOException { public synchronized int read(byte[] buf, int off, int len) throws IOException {
synchronized(unwrappedRpcBuffer) {
// fill the buffer with the next RPC message // fill the buffer with the next RPC message
if (unwrappedRpcBuffer.remaining() == 0) { if (unwrappedRpcBuffer.remaining() == 0) {
readNextRpcPacket(); readNextRpcPacket();
@ -584,7 +583,6 @@ public int read(byte[] buf, int off, int len) throws IOException {
unwrappedRpcBuffer.get(buf, off, readLen); unwrappedRpcBuffer.get(buf, off, readLen);
return readLen; return readLen;
} }
}
// all messages must be RPC SASL wrapped, else an exception is thrown // all messages must be RPC SASL wrapped, else an exception is thrown
private void readNextRpcPacket() throws IOException { private void readNextRpcPacket() throws IOException {