big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-10095. In CodecPool, synchronize pool and codecList separately in order to reduce lock contention. Contributed by Nicolas Liochon

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1541750 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Tsz-wo Sze 2013-11-13 22:50:58 +00:00
parent 732dc44136
commit 3727ac9bde
2 changed files with 19 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-common-project/hadoop-common/CHANGES.txt
View File

@ -378,6 +378,9 @@ Release 2.3.0 - UNRELEASED
HADOOP-9594. Update apache commons math dependency (Timothy St. Clair via HADOOP-9594. Update apache commons math dependency (Timothy St. Clair via
stevel) stevel)
HADOOP-10095. In CodecPool, synchronize pool and codecList separately in
order to reduce lock contention. (Nicolas Liochon via szetszwo)
OPTIMIZATIONS OPTIMIZATIONS
HADOOP-9748. Reduce blocking on UGI.ensureInitialized (daryn) HADOOP-9748. Reduce blocking on UGI.ensureInitialized (daryn)

31
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CodecPool.java
View File

@ -85,16 +85,15 @@ private static <T> T borrow(Map<Class<T>, List<T>> pool,
T codec = null; T codec = null;
// Check if an appropriate codec is available // Check if an appropriate codec is available
List<T> codecList;
synchronized (pool) { synchronized (pool) {
if (pool.containsKey(codecClass)) { codecList = pool.get(codecClass);
List<T> codecList = pool.get(codecClass); }
if (codecList != null) { if (codecList != null) {
synchronized (codecList) { synchronized (codecList) {
if (!codecList.isEmpty()) { if (!codecList.isEmpty()) {
codec = codecList.remove(codecList.size()-1); codec = codecList.remove(codecList.size() - 1);
}
}
} }
} }
} }
@ -105,15 +104,17 @@ private static <T> T borrow(Map<Class<T>, List<T>> pool,
private static <T> void payback(Map<Class<T>, List<T>> pool, T codec) { private static <T> void payback(Map<Class<T>, List<T>> pool, T codec) {
if (codec != null) { if (codec != null) {
Class<T> codecClass = ReflectionUtils.getClass(codec); Class<T> codecClass = ReflectionUtils.getClass(codec);
List<T> codecList;
synchronized (pool) { synchronized (pool) {
if (!pool.containsKey(codecClass)) { codecList = pool.get(codecClass);
pool.put(codecClass, new ArrayList<T>()); if (codecList == null) {
codecList = new ArrayList<T>();
pool.put(codecClass, codecList);
} }
}
List<T> codecList = pool.get(codecClass); synchronized (codecList) {
synchronized (codecList) { codecList.add(codec);
codecList.add(codec);
}
} }
} }
} }