HADOOP-7813. Fix test-patch to use proper numerical comparison when checking javadoc and findbugs warning counts. Contributed by Jonathan Eagles.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1201056 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
27c9b8833b
commit
3cedc5f83f
@ -396,7 +396,7 @@ checkJavadocWarnings () {
|
|||||||
echo "There appear to be $javadocWarnings javadoc warnings generated by the patched build."
|
echo "There appear to be $javadocWarnings javadoc warnings generated by the patched build."
|
||||||
|
|
||||||
### if current warnings greater than OK_JAVADOC_WARNINGS
|
### if current warnings greater than OK_JAVADOC_WARNINGS
|
||||||
if [[ $javadocWarnings > $OK_JAVADOC_WARNINGS ]] ; then
|
if [[ $javadocWarnings -gt $OK_JAVADOC_WARNINGS ]] ; then
|
||||||
JIRA_COMMENT="$JIRA_COMMENT
|
JIRA_COMMENT="$JIRA_COMMENT
|
||||||
|
|
||||||
-1 javadoc. The javadoc tool appears to have generated `expr $(($javadocWarnings-$OK_JAVADOC_WARNINGS))` warning messages."
|
-1 javadoc. The javadoc tool appears to have generated `expr $(($javadocWarnings-$OK_JAVADOC_WARNINGS))` warning messages."
|
||||||
@ -573,7 +573,7 @@ $JIRA_COMMENT_FOOTER"
|
|||||||
done
|
done
|
||||||
|
|
||||||
### if current warnings greater than OK_FINDBUGS_WARNINGS
|
### if current warnings greater than OK_FINDBUGS_WARNINGS
|
||||||
if [[ $findbugsWarnings > $OK_FINDBUGS_WARNINGS ]] ; then
|
if [[ $findbugsWarnings -gt $OK_FINDBUGS_WARNINGS ]] ; then
|
||||||
JIRA_COMMENT="$JIRA_COMMENT
|
JIRA_COMMENT="$JIRA_COMMENT
|
||||||
|
|
||||||
-1 findbugs. The patch appears to introduce `expr $(($findbugsWarnings-$OK_FINDBUGS_WARNINGS))` new Findbugs (version ${findbugs_version}) warnings."
|
-1 findbugs. The patch appears to introduce `expr $(($findbugsWarnings-$OK_FINDBUGS_WARNINGS))` new Findbugs (version ${findbugs_version}) warnings."
|
||||||
|
Loading…
Reference in New Issue
Block a user