HDFS-16181. [SBN Read] Fix display of JournalNode metric RpcRequestCacheMissAmount (#3317)
Co-authored-by: wangzhaohui8 <wangzhaohui8@jd.com>
This commit is contained in:
parent
b8f7c7527a
commit
3ecaa39668
@ -773,7 +773,7 @@ public GetJournaledEditsResponseProto getJournaledEdits(long sinceTxId,
|
||||
.setEditLog(output.toByteString())
|
||||
.build();
|
||||
} catch (JournaledEditsCache.CacheMissException cme) {
|
||||
metrics.rpcRequestCacheMissAmount.add(cme.getCacheMissAmount());
|
||||
metrics.addRpcRequestCacheMissAmount(cme.getCacheMissAmount());
|
||||
throw cme;
|
||||
}
|
||||
}
|
||||
|
@ -51,12 +51,7 @@ class JournalMetrics {
|
||||
@Metric("Number of bytes served via RPC")
|
||||
MutableCounterLong bytesServedViaRpc;
|
||||
|
||||
@Metric
|
||||
MutableStat rpcRequestCacheMissAmount = new MutableStat(
|
||||
"RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
|
||||
"served due to lack of availability in cache, and how many " +
|
||||
"transactions away the request was from being in the cache.",
|
||||
"Misses", "Txns");
|
||||
private MutableStat rpcRequestCacheMissAmount;
|
||||
|
||||
@Metric("Number of RPC requests with zero edits returned")
|
||||
MutableCounterLong rpcEmptyResponses;
|
||||
@ -87,6 +82,11 @@ class JournalMetrics {
|
||||
"syncs" + interval + "s",
|
||||
"Journal sync time", "ops", "latencyMicros", interval);
|
||||
}
|
||||
rpcRequestCacheMissAmount = registry
|
||||
.newStat("RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
|
||||
"served due to lack of availability in cache, and how many " +
|
||||
"transactions away the request was from being in the cache.",
|
||||
"Misses", "Txns");
|
||||
}
|
||||
|
||||
public static JournalMetrics create(Journal j) {
|
||||
@ -149,4 +149,8 @@ public MutableCounterLong getNumEditLogsSynced() {
|
||||
public void incrNumEditLogsSynced() {
|
||||
numEditLogsSynced.incr();
|
||||
}
|
||||
|
||||
public void addRpcRequestCacheMissAmount(long cacheMissAmount) {
|
||||
rpcRequestCacheMissAmount.add(cacheMissAmount);
|
||||
}
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user