HDFS-2646. Hadoop HttpFS introduced 4 findbug warnings. (tucu)
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1221572 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
parent
8626f1bc6c
commit
45620eee68
@ -0,0 +1,12 @@
|
|||||||
|
<FindBugsFilter>
|
||||||
|
<Match>
|
||||||
|
<Class name="org.apache.hadoop.lib.service.instrumentation.InstrumentationService" />
|
||||||
|
<Method name="getToAdd" />
|
||||||
|
<Bug pattern="UL_UNRELEASED_LOCK" />
|
||||||
|
</Match>
|
||||||
|
<Match>
|
||||||
|
<Class name="org.apache.hadoop.fs.http.server.HttpFSServerWebApp" />
|
||||||
|
<Method name="destroy" />
|
||||||
|
<Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD" />
|
||||||
|
</Match>
|
||||||
|
</FindBugsFilter>
|
@ -384,6 +384,13 @@
|
|||||||
</execution>
|
</execution>
|
||||||
</executions>
|
</executions>
|
||||||
</plugin>
|
</plugin>
|
||||||
|
<plugin>
|
||||||
|
<groupId>org.codehaus.mojo</groupId>
|
||||||
|
<artifactId>findbugs-maven-plugin</artifactId>
|
||||||
|
<configuration>
|
||||||
|
<excludeFilterFile>${basedir}/dev-support/findbugsExcludeFile.xml</excludeFilterFile>
|
||||||
|
</configuration>
|
||||||
|
</plugin>
|
||||||
</plugins>
|
</plugins>
|
||||||
</build>
|
</build>
|
||||||
|
|
||||||
|
@ -111,7 +111,7 @@ private static String format(ERROR error, Object... args) {
|
|||||||
}
|
}
|
||||||
template = sb.deleteCharAt(0).toString();
|
template = sb.deleteCharAt(0).toString();
|
||||||
}
|
}
|
||||||
return error + ": " + MessageFormat.format(error.getTemplate(), args);
|
return error + ": " + MessageFormat.format(template, args);
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -42,7 +42,10 @@ public InputStreamEntity(InputStream is) {
|
|||||||
|
|
||||||
@Override
|
@Override
|
||||||
public void write(OutputStream os) throws IOException {
|
public void write(OutputStream os) throws IOException {
|
||||||
is.skip(offset);
|
long skipped = is.skip(offset);
|
||||||
|
if (skipped < offset) {
|
||||||
|
throw new IOException("Requested offset beyond stream size");
|
||||||
|
}
|
||||||
if (len == -1) {
|
if (len == -1) {
|
||||||
IOUtils.copyBytes(is, os, 4096, true);
|
IOUtils.copyBytes(is, os, 4096, true);
|
||||||
} else {
|
} else {
|
||||||
|
@ -180,6 +180,8 @@ Trunk (unreleased changes)
|
|||||||
|
|
||||||
HDFS-2658. HttpFS introduced 70 javadoc warnings. (tucu)
|
HDFS-2658. HttpFS introduced 70 javadoc warnings. (tucu)
|
||||||
|
|
||||||
|
HDFS-2646. Hadoop HttpFS introduced 4 findbug warnings. (tucu)
|
||||||
|
|
||||||
Release 0.23.1 - UNRELEASED
|
Release 0.23.1 - UNRELEASED
|
||||||
|
|
||||||
INCOMPATIBLE CHANGES
|
INCOMPATIBLE CHANGES
|
||||||
|
Loading…
Reference in New Issue
Block a user