big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-18652. Path.suffix raises NullPointerException (#5653). Contributed by Patrick Grandjean.

Browse Source 
Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org>
Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
This commit is contained in:
Patrick GRANDJEAN 2023-05-18 19:46:55 -04:00 committed by GitHub
parent f6770dee47
commit 4627242c44
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
View File

@ -465,7 +465,12 @@ private Path getParentUtil() {
* @return a new path with the suffix added * @return a new path with the suffix added
*/ */
public Path suffix(String suffix) { public Path suffix(String suffix) {
return new Path(getParent(), getName()+suffix); Path parent = getParent();
if (parent == null) {
return new Path("/", getName() + suffix);
}
return new Path(parent, getName() + suffix);
} }
@Override @Override

7
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
View File

@ -528,4 +528,11 @@ public void testSerDeser() throws Throwable {
} }
} }
@Test(timeout = 30000)
public void testSuffixFromRoot() {
Path root = new Path("/");
Assert.assertNull(root.getParent());
Assert.assertEquals(new Path("/bar"), root.suffix("bar"));
}
} }