diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallQueueManager.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallQueueManager.java index c10f839db4..2ee15d3809 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallQueueManager.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/CallQueueManager.java @@ -19,6 +19,7 @@ package org.apache.hadoop.ipc; import java.lang.reflect.Constructor; +import java.lang.reflect.InvocationTargetException; import java.util.concurrent.BlockingQueue; import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicReference; @@ -70,6 +71,9 @@ private > T createCallQueueInstance( return ctor.newInstance(maxLen, ns, conf); } catch (RuntimeException e) { throw e; + } catch (InvocationTargetException e) { + throw new RuntimeException(theClass.getName() + + " could not be constructed.", e.getCause()); } catch (Exception e) { } @@ -79,6 +83,9 @@ private > T createCallQueueInstance( return ctor.newInstance(maxLen); } catch (RuntimeException e) { throw e; + } catch (InvocationTargetException e) { + throw new RuntimeException(theClass.getName() + + " could not be constructed.", e.getCause()); } catch (Exception e) { } @@ -88,6 +95,9 @@ private > T createCallQueueInstance( return ctor.newInstance(); } catch (RuntimeException e) { throw e; + } catch (InvocationTargetException e) { + throw new RuntimeException(theClass.getName() + + " could not be constructed.", e.getCause()); } catch (Exception e) { } diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestCallQueueManager.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestCallQueueManager.java index 51a97506fa..4d659acd46 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestCallQueueManager.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestCallQueueManager.java @@ -19,6 +19,8 @@ package org.apache.hadoop.ipc; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; import java.util.ArrayList; import java.util.HashMap; @@ -219,4 +221,27 @@ public void testSwapUnderContention() throws InterruptedException { assertEquals(totalCallsConsumed, totalCallsCreated); } + + public static class ExceptionFakeCall { + + public ExceptionFakeCall() { + throw new IllegalArgumentException("Exception caused by constructor.!!"); + } + } + + private static final Class> exceptionQueueClass = CallQueueManager + .convertQueueClass(ExceptionFakeCall.class, ExceptionFakeCall.class); + + @Test + public void testInvocationException() throws InterruptedException { + try { + new CallQueueManager(exceptionQueueClass, false, 10, + "", null); + fail(); + } catch (RuntimeException re) { + assertTrue(re.getCause() instanceof IllegalArgumentException); + assertEquals("Exception caused by constructor.!!", re.getCause() + .getMessage()); + } + } } \ No newline at end of file