big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-10448. CacheManager#addInternal tracks bytesNeeded incorrectly when dealing with replication factors other than 1 (Yiqun Lin via cmccabe)

Browse Source
This commit is contained in:
Colin Patrick Mccabe 2016-06-20 18:25:09 -07:00
parent 7adc4d1769
commit 46f1602e89
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/CacheManager.java
View File

@ -396,8 +396,7 @@ private void checkLimit(CachePool pool, String path,
if (pool.getLimit() == CachePoolInfo.LIMIT_UNLIMITED) {
return;
}
if (pool.getBytesNeeded() + (stats.getBytesNeeded() * replication) > pool
.getLimit()) {
if (pool.getBytesNeeded() + stats.getBytesNeeded() > pool.getLimit()) {
throw new InvalidRequestException("Caching path " + path + " of size "
+ stats.getBytesNeeded() / replication + " bytes at replication "
+ replication + " would exceed pool " + pool.getPoolName()
@ -441,7 +440,7 @@ private CacheDirectiveStats computeNeeded(String path, short replication) {
}
}
return new CacheDirectiveStats.Builder()
.setBytesNeeded(requestedBytes)
.setBytesNeeded(requestedBytes * replication)
.setFilesCached(requestedFiles)
.build();
}