From 4a051ba4947dbb993bcfe1eda15c5926465db6ec Mon Sep 17 00:00:00 2001 From: Nanda kumar Date: Sun, 21 Jan 2018 00:40:39 +0530 Subject: [PATCH] HDFS-12940. Ozone: KSM: TestKeySpaceManager#testExpiredOpenKey fails occasionally. Contributed by Nanda kumar. --- .../hadoop/ozone/ksm/KeyManagerImpl.java | 6 ++ .../hadoop/ozone/ksm/KeySpaceManager.java | 5 ++ .../hadoop/utils/BackgroundService.java | 10 ++- .../hadoop/ozone/ksm/TestKeySpaceManager.java | 83 +++++++++++-------- 4 files changed, 68 insertions(+), 36 deletions(-) diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeyManagerImpl.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeyManagerImpl.java index 10c61fc96c..b99103b1a2 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeyManagerImpl.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeyManagerImpl.java @@ -16,6 +16,7 @@ */ package org.apache.hadoop.ozone.ksm; +import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Preconditions; import org.apache.hadoop.ozone.OzoneConsts; import org.apache.hadoop.hdfs.DFSUtil; @@ -128,6 +129,11 @@ public KeyManagerImpl(ScmBlockLocationProtocol scmBlockClient, this.ksmId = ksmId; } + @VisibleForTesting + public BackgroundService getOpenKeyCleanupService() { + return openKeyCleanupService; + } + @Override public void start() { keyDeletingService.start(); diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeySpaceManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeySpaceManager.java index ef311651bb..6139292760 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeySpaceManager.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/ksm/KeySpaceManager.java @@ -234,6 +234,11 @@ private static StorageContainerLocationProtocol getScmContainerClient( return scmContainerClient; } + @VisibleForTesting + public KeyManager getKeyManager() { + return keyManager; + } + @VisibleForTesting public ScmInfo getScmInfo() throws IOException { return scmBlockClient.getScmInfo(); diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/BackgroundService.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/BackgroundService.java index 4c789e993a..2ff4e5562f 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/BackgroundService.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/utils/BackgroundService.java @@ -55,6 +55,7 @@ public abstract class BackgroundService { private final long interval; private final long serviceTimeout; private final TimeUnit unit; + private final PeriodicalTask service; public BackgroundService(String serviceName, long interval, TimeUnit unit, int threadPoolSize, long serviceTimeout) { @@ -70,6 +71,7 @@ public BackgroundService(String serviceName, long interval, .setNameFormat(serviceName + "#%d") .build(); exec = Executors.newScheduledThreadPool(threadPoolSize, threadFactory); + service = new PeriodicalTask(); } protected ExecutorService getExecutorService() { @@ -81,10 +83,14 @@ public int getThreadCount() { return threadGroup.activeCount(); } + @VisibleForTesting + public void triggerBackgroundTaskForTesting() { + service.run(); + } // start service public void start() { - exec.scheduleWithFixedDelay(new PeriodicalTask(), 0, interval, unit); + exec.scheduleWithFixedDelay(service, 0, interval, unit); } public abstract BackgroundTaskQueue getTasks(); @@ -95,7 +101,7 @@ public void start() { */ public class PeriodicalTask implements Runnable { @Override - public void run() { + public synchronized void run() { LOG.debug("Running background service : {}", serviceName); BackgroundTaskQueue tasks = getTasks(); if (tasks.isEmpty()) { diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java index c8427f3950..eeaad25378 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/ozone/ksm/TestKeySpaceManager.java @@ -56,6 +56,7 @@ import org.apache.hadoop.ozone.web.response.ListKeys; import org.apache.hadoop.ozone.web.response.ListVolumes; import org.apache.hadoop.util.Time; +import org.apache.hadoop.utils.BackgroundService; import org.apache.hadoop.utils.MetadataKeyFilters; import org.apache.hadoop.utils.MetadataStore; import org.junit.AfterClass; @@ -83,7 +84,6 @@ import java.util.stream.Collectors; import java.util.stream.Stream; -import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_OPEN_KEY_CLEANUP_SERVICE_INTERVAL_SECONDS; import static org.apache.hadoop.ozone.OzoneConfigKeys.OZONE_OPEN_KEY_EXPIRE_THRESHOLD_SECONDS; import static org.apache.hadoop.ozone.OzoneConsts.DELETING_KEY_PREFIX; import static org.apache.hadoop.ozone.ksm.KSMConfigKeys.OZONE_KSM_ADDRESS_KEY; @@ -121,7 +121,6 @@ public static void init() throws Exception { ksmId = UUID.randomUUID().toString(); conf.set(OzoneConfigKeys.OZONE_HANDLER_TYPE_KEY, OzoneConsts.OZONE_HANDLER_DISTRIBUTED); - conf.setInt(OZONE_OPEN_KEY_CLEANUP_SERVICE_INTERVAL_SECONDS, 2); conf.setInt(OZONE_OPEN_KEY_EXPIRE_THRESHOLD_SECONDS, 2); cluster = new MiniOzoneClassicCluster.Builder(conf) .setHandlerType(OzoneConsts.OZONE_HANDLER_DISTRIBUTED) @@ -1080,6 +1079,9 @@ public void testGetScmInfo() throws IOException { @Test public void testExpiredOpenKey() throws Exception { + BackgroundService openKeyCleanUpService = ((KeyManagerImpl)cluster + .getKeySpaceManager().getKeyManager()).getOpenKeyCleanupService(); + String userName = "user" + RandomStringUtils.randomNumeric(5); String adminName = "admin" + RandomStringUtils.randomNumeric(5); String volumeName = "volume" + RandomStringUtils.randomNumeric(5); @@ -1098,54 +1100,67 @@ public void testExpiredOpenKey() throws Exception { // open some keys. - Thread.sleep(1000); - KeyArgs keyArgs1 = new KeyArgs("testKey1", bucketArgs); KeyArgs keyArgs2 = new KeyArgs("testKey2", bucketArgs); KeyArgs keyArgs3 = new KeyArgs("testKey3", bucketArgs); KeyArgs keyArgs4 = new KeyArgs("testKey4", bucketArgs); List openKeys; - try (OutputStream s1 = storageHandler.newKeyWriter(keyArgs1); - OutputStream s2 = storageHandler.newKeyWriter(keyArgs2)) { - storageHandler.newKeyWriter(keyArgs3); - storageHandler.newKeyWriter(keyArgs4); - // now all k1-k4 should be in open state - openKeys = cluster.getKeySpaceManager() - .getMetadataManager().getExpiredOpenKeys(); - Assert.assertEquals(0, openKeys.size()); + storageHandler.newKeyWriter(keyArgs1); + storageHandler.newKeyWriter(keyArgs2); + storageHandler.newKeyWriter(keyArgs3); + storageHandler.newKeyWriter(keyArgs4); - Thread.sleep(2000); + Set expected = Stream.of( + "testKey1", "testKey2", "testKey3", "testKey4") + .collect(Collectors.toSet()); - openKeys = cluster.getKeySpaceManager().getMetadataManager() - .getExpiredOpenKeys(); - Assert.assertEquals(4, openKeys.size()); + // Now all k1-k4 should be in open state, so ExpiredOpenKeys should not + // contain these values. + openKeys = cluster.getKeySpaceManager() + .getMetadataManager().getExpiredOpenKeys(); - Set expected = Stream.of( - "testKey1", "testKey2", "testKey3", "testKey4") - .collect(Collectors.toSet()); - openKeys = - cluster.getKeySpaceManager().getMetadataManager().getExpiredOpenKeys(); - for (BlockGroup bg : openKeys) { - String[] subs = bg.getGroupID().split("/"); - String keyName = subs[subs.length - 1]; - Assert.assertTrue(expected.remove(keyName)); - } - Assert.assertEquals(0, expected.size()); + for (BlockGroup bg : openKeys) { + String[] subs = bg.getGroupID().split("/"); + String keyName = subs[subs.length - 1]; + Assert.assertFalse(expected.contains(keyName)); } + Thread.sleep(2000); + // Now all k1-k4 should be in ExpiredOpenKeys + openKeys = cluster.getKeySpaceManager() + .getMetadataManager().getExpiredOpenKeys(); + for (BlockGroup bg : openKeys) { + String[] subs = bg.getGroupID().split("/"); + String keyName = subs[subs.length - 1]; + if (expected.contains(keyName)) { + expected.remove(keyName); + } + } + Assert.assertEquals(0, expected.size()); + KeyArgs keyArgs5 = new KeyArgs("testKey5", bucketArgs); storageHandler.newKeyWriter(keyArgs5); - // k1 and k2 are closed, so should be removed from meta data, k3 and k4 - // should still be there. + openKeyCleanUpService.triggerBackgroundTaskForTesting(); Thread.sleep(2000); - + // now all k1-k4 should have been removed by the clean-up task, only k5 + // should be present in ExpiredOpenKeys. openKeys = cluster.getKeySpaceManager().getMetadataManager().getExpiredOpenKeys(); - Assert.assertEquals(1, openKeys.size()); - String[] subs = openKeys.get(0).getGroupID().split("/"); - String keyName = subs[subs.length - 1]; - Assert.assertEquals("testKey5", keyName); + System.out.println(openKeys); + boolean key5found = false; + Set removed = Stream.of( + "testKey1", "testKey2", "testKey3", "testKey4") + .collect(Collectors.toSet()); + for (BlockGroup bg : openKeys) { + String[] subs = bg.getGroupID().split("/"); + String keyName = subs[subs.length - 1]; + Assert.assertFalse(removed.contains(keyName)); + if (keyName.equals("testKey5")) { + key5found = true; + } + } + Assert.assertTrue(key5found); } /**