big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-4035. LightWeightGSet and LightWeightHashSet increment a volatile without synchronization. Contributed by Eli Collins

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1430595 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Eli Collins 2013-01-08 22:43:40 +00:00
parent 6d4a091567
commit 4ca58bd57c
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -467,6 +467,9 @@ Release 2.0.3-alpha - Unreleased
HDFS-4034. Remove redundant null checks. (eli) HDFS-4034. Remove redundant null checks. (eli)
HDFS-4035. LightWeightGSet and LightWeightHashSet increment a
volatile without synchronization. (eli)
OPTIMIZATIONS OPTIMIZATIONS
BUG FIXES BUG FIXES

16
hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
View File

@ -308,4 +308,20 @@
<Field name="pendingReceivedRequests" /> <Field name="pendingReceivedRequests" />
<Bug pattern="VO_VOLATILE_INCREMENT" /> <Bug pattern="VO_VOLATILE_INCREMENT" />
</Match> </Match>
<!-- The "LightWeight" classes are explicitly not thread safe -->
<Match>
<Class name="org.apache.hadoop.hdfs.util.LightWeightGSet" />
<Field name="modification" />
<Bug pattern="VO_VOLATILE_INCREMENT" />
</Match>
<Match>
<Class name="org.apache.hadoop.hdfs.util.LightWeightHashSet" />
<Field name="modification" />
<Bug pattern="VO_VOLATILE_INCREMENT" />
</Match>
<Match>
<Class name="org.apache.hadoop.hdfs.util.LightWeightLinkedSet" />
<Field name="modification" />
<Bug pattern="VO_VOLATILE_INCREMENT" />
</Match>
</FindBugsFilter> </FindBugsFilter>