big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-9027. Fixed LevelDBCacheTimelineStore initialization.

Browse Source 
Contributed by Prabhu Joseph
This commit is contained in:
Eric Yang 2019-05-31 14:31:44 -04:00
parent 1ae062c818
commit 4cb559ea7b
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/src/main/java/org/apache/hadoop/yarn/server/timeline/LevelDBCacheTimelineStore.java
View File

@ -38,6 +38,7 @@
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.util.Map; import java.util.Map;
import java.util.concurrent.atomic.AtomicInteger;
/** /**
* LevelDB implementation of {@link KeyValueBasedTimelineStore}. This * LevelDB implementation of {@link KeyValueBasedTimelineStore}. This
@ -63,6 +64,8 @@ public class LevelDBCacheTimelineStore extends KeyValueBasedTimelineStore {
private String dbId; private String dbId;
private DB entityDb; private DB entityDb;
private Configuration configuration; private Configuration configuration;
private static final AtomicInteger DB_COUNTER = new AtomicInteger(0);
private static final String CACHED_LDB_FILENAME = "db";
public LevelDBCacheTimelineStore(String id, String name) { public LevelDBCacheTimelineStore(String id, String name) {
super(name); super(name);
@ -76,6 +79,11 @@ public LevelDBCacheTimelineStore(String id) {
this(id, LevelDBCacheTimelineStore.class.getName()); this(id, LevelDBCacheTimelineStore.class.getName());
} }
public LevelDBCacheTimelineStore() {
this(CACHED_LDB_FILENAME + String.valueOf(DB_COUNTER.getAndIncrement()),
LevelDBCacheTimelineStore.class.getName());
}
@Override @Override
protected synchronized void serviceInit(Configuration conf) throws Exception { protected synchronized void serviceInit(Configuration conf) throws Exception {
configuration = conf; configuration = conf;

13
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage/src/test/java/org/apache/hadoop/yarn/server/timeline/TestLevelDBCacheTimelineStore.java
View File

@ -19,9 +19,11 @@
package org.apache.hadoop.yarn.server.timeline; package org.apache.hadoop.yarn.server.timeline;
import org.apache.hadoop.yarn.conf.YarnConfiguration; import org.apache.hadoop.yarn.conf.YarnConfiguration;
import org.apache.hadoop.util.ReflectionUtils;
import org.junit.After; import org.junit.After;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import static org.junit.Assert.assertNotNull;
import java.io.IOException; import java.io.IOException;
@ -46,6 +48,17 @@ public TimelineStore getTimelineStore() {
return store; return store;
} }
@Test
public void testDefaultConstructor() {
TimelineStore store = null;
try {
store = ReflectionUtils.newInstance(LevelDBCacheTimelineStore.class,
new YarnConfiguration());
} finally {
assertNotNull("LevelDBCacheTimelineStore failed to instantiate", store);
}
}
@Test @Test
public void testGetSingleEntity() throws IOException { public void testGetSingleEntity() throws IOException {
super.testGetSingleEntity(); super.testGetSingleEntity();