From 4cdbdce752e192b45c2b9756c2d4bd24ceffdabd Mon Sep 17 00:00:00 2001 From: Rushabh Shah Date: Fri, 4 May 2018 15:36:13 -0500 Subject: [PATCH] HADOOP-14841 Kms client should disconnect if unable to get output stream from connection. Contributed by Rushabh S Shah --- .../hadoop/crypto/key/kms/KMSClientProvider.java | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java index f97fde7ac9..45097efae9 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java @@ -447,12 +447,21 @@ private T call(HttpURLConnection conn, Object jsonOutput, int expectedResponse, Class klass, int authRetryCount) throws IOException { T ret = null; + OutputStream os = null; try { if (jsonOutput != null) { - writeJson(jsonOutput, conn.getOutputStream()); + os = conn.getOutputStream(); + writeJson(jsonOutput, os); } } catch (IOException ex) { - IOUtils.closeStream(conn.getInputStream()); + // The payload is not serialized if getOutputStream fails. + // Calling getInputStream will issue the put/post request with no payload + // which causes HTTP 500 server error. + if (os == null) { + conn.disconnect(); + } else { + IOUtils.closeStream(conn.getInputStream()); + } throw ex; } if ((conn.getResponseCode() == HttpURLConnection.HTTP_FORBIDDEN