big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-6367. EnumSetParam$Domain#parse fails for parameter containing more than one enum. Contributed by Yi Liu.

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1594150 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Uma Maheswara Rao G 2014-05-13 07:34:32 +00:00
parent 089adaa999
commit 4f399bb4ba
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -455,6 +455,9 @@ Release 2.5.0 - UNRELEASED
HDFS-5522. Datanode disk error check may be incorrectly skipped. HDFS-5522. Datanode disk error check may be incorrectly skipped.
(Rushabh S Shah via kihwal) (Rushabh S Shah via kihwal)
HDFS-6367. EnumSetParam$Domain#parse fails for parameter containing more than one enum.
(Yi Liu via umamahesh)
Release 2.4.1 - UNRELEASED Release 2.4.1 - UNRELEASED
INCOMPATIBLE CHANGES INCOMPATIBLE CHANGES

4
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/web/resources/EnumSetParam.java
View File

@ -79,8 +79,8 @@ final EnumSet<E> parse(final String str) {
final EnumSet<E> set = EnumSet.noneOf(enumClass); final EnumSet<E> set = EnumSet.noneOf(enumClass);
if (!str.isEmpty()) { if (!str.isEmpty()) {
for(int i, j = 0; j >= 0; ) { for(int i, j = 0; j >= 0; ) {
i = j; i = j > 0 ? j + 1 : 0;
j = str.indexOf(',', i+1); j = str.indexOf(',', i);
final String sub = j >= 0? str.substring(i, j): str.substring(i); final String sub = j >= 0? str.substring(i, j): str.substring(i);
set.add(Enum.valueOf(enumClass, sub.trim().toUpperCase())); set.add(Enum.valueOf(enumClass, sub.trim().toUpperCase()));
} }

11
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/web/resources/TestParam.java
View File

@ -21,12 +21,14 @@
import static org.junit.Assert.assertNull; import static org.junit.Assert.assertNull;
import java.util.Arrays; import java.util.Arrays;
import java.util.EnumSet;
import java.util.List; import java.util.List;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.fs.CommonConfigurationKeysPublic; import org.apache.hadoop.fs.CommonConfigurationKeysPublic;
import org.apache.hadoop.fs.Options;
import org.apache.hadoop.fs.Path; import org.apache.hadoop.fs.Path;
import org.apache.hadoop.fs.permission.AclEntry; import org.apache.hadoop.fs.permission.AclEntry;
import org.apache.hadoop.fs.permission.FsPermission; import org.apache.hadoop.fs.permission.FsPermission;
@ -346,4 +348,13 @@ public void testAclPermissionParam() {
} }
} }
@Test
public void testRenameOptionSetParam() {
final RenameOptionSetParam p = new RenameOptionSetParam(
Options.Rename.OVERWRITE, Options.Rename.NONE);
final RenameOptionSetParam p1 = new RenameOptionSetParam(
p.getValueString());
Assert.assertEquals(p1.getValue(), EnumSet.of(
Options.Rename.OVERWRITE, Options.Rename.NONE));
}
} }