big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-7818. Remove privileged operation warnings during container launch for the ContainerRuntimes. Contributed by Shane Kumpf

Browse Source
This commit is contained in:
Billie Rinaldi 2018-05-04 08:53:55 -07:00
parent a3b416f69d
commit 502914ca32
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DefaultLinuxContainerRuntime.java
View File

@ -108,6 +108,9 @@ public void launchContainer(ContainerRuntimeContext ctx)
launchOp.appendArgs(tcCommandFile); launchOp.appendArgs(tcCommandFile);
} }
// Some failures here are acceptable. Let the calling executor decide.
launchOp.disableFailureLogging();
//List<String> -> stored as List -> fetched/converted to List<String> //List<String> -> stored as List -> fetched/converted to List<String>
//we can't do better here thanks to type-erasure //we can't do better here thanks to type-erasure
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
@ -118,8 +121,6 @@ public void launchContainer(ContainerRuntimeContext ctx)
privilegedOperationExecutor.executePrivilegedOperation(prefixCommands, privilegedOperationExecutor.executePrivilegedOperation(prefixCommands,
launchOp, null, null, false, false); launchOp, null, null, false, false);
} catch (PrivilegedOperationException e) { } catch (PrivilegedOperationException e) {
LOG.warn("Launch container failed. Exception: ", e);
throw new ContainerExecutionException("Launch container failed", e throw new ContainerExecutionException("Launch container failed", e
.getExitCode(), e.getOutput(), e.getErrorOutput()); .getExitCode(), e.getOutput(), e.getErrorOutput());
} }

14
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/runtime/DockerLinuxContainerRuntime.java
View File

@ -914,13 +914,13 @@ public void launchContainer(ContainerRuntimeContext ctx)
PrivilegedOperation launchOp = buildLaunchOp(ctx, PrivilegedOperation launchOp = buildLaunchOp(ctx,
commandFile, runCommand); commandFile, runCommand);
// Some failures here are acceptable. Let the calling executor decide.
launchOp.disableFailureLogging();
try { try {
privilegedOperationExecutor.executePrivilegedOperation(null, privilegedOperationExecutor.executePrivilegedOperation(null,
launchOp, null, null, false, false); launchOp, null, null, false, false);
} catch (PrivilegedOperationException e) { } catch (PrivilegedOperationException e) {
LOG.warn("Launch container failed. Exception: ", e);
LOG.info("Docker command used: " + runCommand);
throw new ContainerExecutionException("Launch container failed", e throw new ContainerExecutionException("Launch container failed", e
.getExitCode(), e.getOutput(), e.getErrorOutput()); .getExitCode(), e.getOutput(), e.getErrorOutput());
} }
@ -943,14 +943,14 @@ public void relaunchContainer(ContainerRuntimeContext ctx)
PrivilegedOperation launchOp = buildLaunchOp(ctx, commandFile, PrivilegedOperation launchOp = buildLaunchOp(ctx, commandFile,
startCommand); startCommand);
// Some failures here are acceptable. Let the calling executor decide.
launchOp.disableFailureLogging();
try { try {
privilegedOperationExecutor.executePrivilegedOperation(null, privilegedOperationExecutor.executePrivilegedOperation(null,
launchOp, null, null, false, false); launchOp, null, null, false, false);
} catch (PrivilegedOperationException e) { } catch (PrivilegedOperationException e) {
LOG.warn("Relaunch container failed. Exception: ", e); throw new ContainerExecutionException("Relaunch container failed", e
LOG.info("Docker command used: " + startCommand);
throw new ContainerExecutionException("Launch container failed", e
.getExitCode(), e.getOutput(), e.getErrorOutput()); .getExitCode(), e.getOutput(), e.getErrorOutput());
} }
} else { } else {