big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-2568. Use a set to manage child sockets in XceiverServer. Contributed by Harsh J

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1204122 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Eli Collins 2011-11-20 04:13:32 +00:00
parent b2313021fd
commit 513718f92d
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
View File

@ -124,6 +124,9 @@ Release 0.23.1 - UNRELEASED
HDFS-208. name node should warn if only one dir is listed in dfs.name.dir. HDFS-208. name node should warn if only one dir is listed in dfs.name.dir.
(Uma Maheswara Rao G via eli) (Uma Maheswara Rao G via eli)
HDFS-2568. Use a set to manage child sockets in XceiverServer.
(harsh via eli)
HDFS-2536. Remove unused imports. (harsh via eli) HDFS-2536. Remove unused imports. (harsh via eli)
OPTIMIZATIONS OPTIMIZATIONS

2
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiver.java
View File

@ -126,7 +126,7 @@ private void updateCurrentThreadName(String status) {
public void run() { public void run() {
int opsProcessed = 0; int opsProcessed = 0;
Op op = null; Op op = null;
dataXceiverServer.childSockets.put(s, s); dataXceiverServer.childSockets.add(s);
try { try {
int stdTimeout = s.getSoTimeout(); int stdTimeout = s.getSoTimeout();

10
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataXceiverServer.java
View File

@ -23,9 +23,9 @@
import java.net.SocketTimeoutException; import java.net.SocketTimeoutException;
import java.nio.channels.AsynchronousCloseException; import java.nio.channels.AsynchronousCloseException;
import java.util.Collections; import java.util.Collections;
import java.util.HashMap; import java.util.HashSet;
import java.util.Iterator; import java.util.Iterator;
import java.util.Map; import java.util.Set;
import org.apache.commons.logging.Log; import org.apache.commons.logging.Log;
import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.conf.Configuration;
@ -48,8 +48,8 @@ class DataXceiverServer implements Runnable {
ServerSocket ss; ServerSocket ss;
DataNode datanode; DataNode datanode;
// Record all sockets opened for data transfer // Record all sockets opened for data transfer
Map<Socket, Socket> childSockets = Collections.synchronizedMap( Set<Socket> childSockets = Collections.synchronizedSet(
new HashMap<Socket, Socket>()); new HashSet<Socket>());
/** /**
* Maximal number of concurrent xceivers per node. * Maximal number of concurrent xceivers per node.
@ -184,7 +184,7 @@ void kill() {
// close all the sockets that were accepted earlier // close all the sockets that were accepted earlier
synchronized (childSockets) { synchronized (childSockets) {
for (Iterator<Socket> it = childSockets.values().iterator(); for (Iterator<Socket> it = childSockets.iterator();
it.hasNext();) { it.hasNext();) {
Socket thissock = it.next(); Socket thissock = it.next();
try { try {