From 53a86e2b8ecb83b666d4ed223fc270e1a46642c1 Mon Sep 17 00:00:00 2001
From: Gabor Bota <gabor.bota@cloudera.com>
Date: Fri, 29 Mar 2019 17:26:20 +0100
Subject: [PATCH] HADOOP-16220. Add findbugs ignores for unjustified issues
 during update to guava to 27.0-jre in hadoop-project

This closes #665

Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
---
 .../dev-support/findbugsExcludeFile.xml       | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
index 3b770f3f80..f9d834ee43 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
+++ b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
@@ -185,6 +185,28 @@
        <Bug pattern="OS_OPEN_STREAM" />
      </Match>
 
+     <!-- guava 27.0 update: @Nullable is not detected, however it's there -->
+     <Match>
+       <Class name="org.apache.hadoop.hdfs.qjournal.server.Journal" />
+       <Method name="persistPaxosData" />
+       <Bug pattern="NP_NULL_PARAM_DEREF" />
+     </Match>
+
+
+     <!-- guava 27.0 update: @Nullable is not detected, however it's there -->
+     <Match>
+       <Class name="org.apache.hadoop.hdfs.qjournal.server.JournalNode" />
+       <Method name="getLogDir" />
+       <Bug pattern="NP_NULL_PARAM_DEREF" />
+     </Match>
+
+      <!-- guava 27.0 update: redundant nullcheck (assert for not null) -->
+      <Match>
+        <Class name="org.apache.hadoop.hdfs.qjournal.server.JournalNode" />
+        <Method name="getLogDir" />
+        <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE" />
+      </Match>
+
      <!-- Don't complain about LocalDatanodeInfo's anonymous class -->
      <Match>
        <Class name="org.apache.hadoop.hdfs.client.impl.BlockReaderLocal$LocalDatanodeInfo$1" />