big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-17118 Fixed a couple checkstyle warnings in TestObserverReadProxyProvider (#5880)

Browse Source
This commit is contained in:
Xing Lin 2023-08-05 12:27:52 -07:00 committed by GitHub
parent 001d353cc5
commit 55e8301470
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverReadProxyProvider.java
View File

@ -46,7 +46,6 @@
import org.junit.BeforeClass; import org.junit.BeforeClass;
import org.junit.Test; import org.junit.Test;
import org.mockito.Mockito; import org.mockito.Mockito;
import org.mockito.MockitoAnnotations;
import org.mockito.invocation.InvocationOnMock; import org.mockito.invocation.InvocationOnMock;
import org.mockito.stubbing.Answer; import org.mockito.stubbing.Answer;
import org.slf4j.event.Level; import org.slf4j.event.Level;
@ -59,8 +58,8 @@
import static org.junit.Assert.assertNull; import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue; import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail; import static org.junit.Assert.fail;
import static org.mockito.Matchers.any; import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Matchers.anyLong; import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.Mockito.mock; import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verifyNoMoreInteractions; import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.mockito.Mockito.when; import static org.mockito.Mockito.when;
@ -367,8 +366,10 @@ public void testGetHAServiceStateWithTimeout() throws Exception {
setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT); setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT);
final HAServiceState state = HAServiceState.STANDBY; final HAServiceState state = HAServiceState.STANDBY;
@SuppressWarnings("unchecked")
NNProxyInfo<ClientProtocol> dummyNNProxyInfo = NNProxyInfo<ClientProtocol> dummyNNProxyInfo =
(NNProxyInfo<ClientProtocol>) mock(NNProxyInfo.class); (NNProxyInfo<ClientProtocol>) mock(NNProxyInfo.class);
@SuppressWarnings("unchecked")
Future<HAServiceState> task = mock(Future.class); Future<HAServiceState> task = mock(Future.class);
when(task.get(anyLong(), any(TimeUnit.class))).thenReturn(state); when(task.get(anyLong(), any(TimeUnit.class))).thenReturn(state);
@ -389,8 +390,10 @@ public void testTimeoutExceptionGetHAServiceStateWithTimeout() throws Exception
proxyLog.clearOutput(); proxyLog.clearOutput();
setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT); setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT);
@SuppressWarnings("unchecked")
NNProxyInfo<ClientProtocol> dummyNNProxyInfo = NNProxyInfo<ClientProtocol> dummyNNProxyInfo =
(NNProxyInfo<ClientProtocol>) Mockito.mock(NNProxyInfo.class); (NNProxyInfo<ClientProtocol>) Mockito.mock(NNProxyInfo.class);
@SuppressWarnings("unchecked")
Future<HAServiceState> task = mock(Future.class); Future<HAServiceState> task = mock(Future.class);
TimeoutException e = new TimeoutException("Timeout"); TimeoutException e = new TimeoutException("Timeout");
when(task.get(anyLong(), any(TimeUnit.class))).thenThrow(e); when(task.get(anyLong(), any(TimeUnit.class))).thenThrow(e);
@ -413,8 +416,10 @@ public void testInterruptedExceptionGetHAServiceStateWithTimeout() throws Except
proxyLog.clearOutput(); proxyLog.clearOutput();
setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT); setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT);
@SuppressWarnings("unchecked")
NNProxyInfo<ClientProtocol> dummyNNProxyInfo = NNProxyInfo<ClientProtocol> dummyNNProxyInfo =
(NNProxyInfo<ClientProtocol>) Mockito.mock(NNProxyInfo.class); (NNProxyInfo<ClientProtocol>) Mockito.mock(NNProxyInfo.class);
@SuppressWarnings("unchecked")
Future<HAServiceState> task = mock(Future.class); Future<HAServiceState> task = mock(Future.class);
InterruptedException e = new InterruptedException("Interrupted"); InterruptedException e = new InterruptedException("Interrupted");
when(task.get(anyLong(), any(TimeUnit.class))).thenThrow(e); when(task.get(anyLong(), any(TimeUnit.class))).thenThrow(e);
@ -436,8 +441,10 @@ public void testExecutionExceptionGetHAServiceStateWithTimeout() throws Exceptio
proxyLog.clearOutput(); proxyLog.clearOutput();
setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT); setupProxyProvider(1, NAMENODE_HA_STATE_PROBE_TIMEOUT_SHORT);
@SuppressWarnings("unchecked")
NNProxyInfo<ClientProtocol> dummyNNProxyInfo = NNProxyInfo<ClientProtocol> dummyNNProxyInfo =
(NNProxyInfo<ClientProtocol>) Mockito.mock(NNProxyInfo.class); (NNProxyInfo<ClientProtocol>) Mockito.mock(NNProxyInfo.class);
@SuppressWarnings("unchecked")
Future<HAServiceState> task = mock(Future.class); Future<HAServiceState> task = mock(Future.class);
Exception e = new ExecutionException(new InterruptedException("Interrupted")); Exception e = new ExecutionException(new InterruptedException("Interrupted"));
when(task.get(anyLong(), any(TimeUnit.class))).thenThrow(e); when(task.get(anyLong(), any(TimeUnit.class))).thenThrow(e);
@ -452,7 +459,7 @@ public void testExecutionExceptionGetHAServiceStateWithTimeout() throws Exceptio
} }
/** /**
* Test GetHAServiceState when timeout is disabled (test the else { task.get() } code path) * Test GetHAServiceState when timeout is disabled (test the else { task.get() } code path).
*/ */
@Test @Test
public void testGetHAServiceStateWithoutTimeout() throws Exception { public void testGetHAServiceStateWithoutTimeout() throws Exception {
@ -460,8 +467,10 @@ public void testGetHAServiceStateWithoutTimeout() throws Exception {
setupProxyProvider(1, 0); setupProxyProvider(1, 0);
final HAServiceState state = HAServiceState.STANDBY; final HAServiceState state = HAServiceState.STANDBY;
@SuppressWarnings("unchecked")
NNProxyInfo<ClientProtocol> dummyNNProxyInfo = NNProxyInfo<ClientProtocol> dummyNNProxyInfo =
(NNProxyInfo<ClientProtocol>) mock(NNProxyInfo.class); (NNProxyInfo<ClientProtocol>) mock(NNProxyInfo.class);
@SuppressWarnings("unchecked")
Future<HAServiceState> task = mock(Future.class); Future<HAServiceState> task = mock(Future.class);
when(task.get()).thenReturn(state); when(task.get()).thenReturn(state);