diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 48be07af1a..864865fb40 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -752,6 +752,9 @@ Release 2.8.0 - UNRELEASED HADOOP-11927. Fix "undefined reference to dlopen" error when compiling libhadooppipes (Xianyin Xin via Colin P. McCabe) + HADOOP-8751. NPE in Token.toString() when Token is constructed using null + identifier. (kanaka kumar avvaru via aajisaka) + Release 2.7.1 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java index 32a8cd3d97..bd254e6d8d 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java @@ -70,10 +70,10 @@ public Token(T id, SecretManager mgr) { * @param service the service for this token */ public Token(byte[] identifier, byte[] password, Text kind, Text service) { - this.identifier = identifier; - this.password = password; - this.kind = kind; - this.service = service; + this.identifier = (identifier == null)? new byte[0] : identifier; + this.password = (password == null)? new byte[0] : password; + this.kind = (kind == null)? new Text() : kind; + this.service = (service == null)? new Text() : service; } /** diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java index 239b8414eb..b41ff15251 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java @@ -44,6 +44,7 @@ import org.apache.hadoop.security.token.SecretManager; import org.apache.hadoop.security.token.Token; import org.apache.hadoop.security.token.SecretManager.InvalidToken; +import org.apache.hadoop.security.token.TokenIdentifier; import org.apache.hadoop.security.token.delegation.AbstractDelegationTokenSecretManager.DelegationTokenInformation; import org.apache.hadoop.util.Daemon; import org.apache.hadoop.util.Time; @@ -539,4 +540,18 @@ public void testDelegationKeyEqualAndHash() { Assert.assertEquals(key1, key2); Assert.assertFalse(key2.equals(key3)); } + + @Test + public void testEmptyToken() throws IOException { + Token token1 = new Token(); + + Token token2 = new Token(new byte[0], new byte[0], + new Text(), new Text()); + assertEquals(token1, token2); + assertEquals(token1.encodeToUrlString(), token2.encodeToUrlString()); + + token2 = new Token(null, null, null, null); + assertEquals(token1, token2); + assertEquals(token1.encodeToUrlString(), token2.encodeToUrlString()); + } }