From 5d5a22a878d185dd996a921d681863c4bc44e6b8 Mon Sep 17 00:00:00 2001
From: Andrew Wang <wang@apache.org>
Date: Fri, 15 Jan 2016 11:58:56 -0800
Subject: [PATCH] HADOOP-12713. Disable spurious checkstyle checks.

---
 .../src/main/resources/checkstyle/checkstyle.xml     | 12 +++++++-----
 hadoop-common-project/hadoop-common/CHANGES.txt      |  2 ++
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml b/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
index de7319c9e1..74faa48413 100644
--- a/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
+++ b/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
@@ -61,7 +61,8 @@
     <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
     <module name="Translation"/>
 
-    <module name="FileLength"/>
+    <!-- We have many existing long files, this check ends up being spurious -->
+    <!--<module name="FileLength">-->
     <module name="FileTabCharacter"/>
 
     <module name="TreeWalker">
@@ -130,13 +131,14 @@
         <module name="ParenPad"/>
         <module name="TypecastParenPad"/>
         <module name="WhitespaceAfter">
-	    	<property name="tokens" value="COMMA, SEMI"/>
-		</module>
+          <property name="tokens" value="COMMA, SEMI"/>
+        </module>
 
 
         <!-- Modifier Checks                                    -->
         <!-- See http://checkstyle.sf.net/config_modifiers.html -->
-        <module name="ModifierOrder"/>
+        <!-- This one is nitty, disable -->
+        <!-- <module name="ModifierOrder"/> -->
         <module name="RedundantModifier"/>
 
 
@@ -178,7 +180,7 @@
             <property name="basicOffset" value="2" />
             <property name="caseIndent" value="0" />
         </module> 
-        <module name="TodoComment"/>
+        <!--<module name="TodoComment"/>-->
         <module name="UpperEll"/>
 
     </module>
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 90013af69a..19f6fec55f 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -669,6 +669,8 @@ Release 2.9.0 - UNRELEASED
     HADOOP-8887. Use a Maven plugin to build the native code using CMake
     (cmccabe)
 
+    HADOOP-12713. Disable spurious checkstyle checks. (wang)
+
   BUG FIXES
 
     HADOOP-12655. TestHttpServer.testBindAddress bind port range is wider