From 5ed663b32fa0c482a09f8ee120c86b3fd4b9e71d Mon Sep 17 00:00:00 2001
From: Nandakumar <nanda@apache.org>
Date: Wed, 11 Oct 2017 17:28:09 +0530
Subject: [PATCH] HDFS-12631. Ozone: ContainerStorageLocation#scmUsage should
 count only SCM usage. Contributed by Xiaoyu Yao.

---
 .../common/impl/ContainerStorageLocation.java      | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerStorageLocation.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerStorageLocation.java
index ebf0bf8629..07a3a539e7 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerStorageLocation.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerStorageLocation.java
@@ -25,6 +25,7 @@
 import org.apache.hadoop.hdfs.server.datanode.StorageLocation;
 import org.apache.hadoop.hdfs.server.protocol.DatanodeStorage;
 import org.apache.hadoop.io.IOUtils;
+import org.apache.hadoop.ozone.OzoneConsts;
 import org.apache.hadoop.util.ShutdownHookManager;
 import org.apache.hadoop.util.Time;
 import org.slf4j.Logger;
@@ -37,6 +38,7 @@
 import java.io.FileOutputStream;
 import java.net.URI;
 import java.nio.charset.StandardCharsets;
+import java.nio.file.Paths;
 import java.util.Scanner;
 
 import static org.apache.hadoop.util.RunJar.SHUTDOWN_HOOK_PRIORITY;
@@ -62,7 +64,17 @@ public ContainerStorageLocation(StorageLocation dataLoc, Configuration conf)
       throws IOException {
     this.dataLocation = dataLoc;
     this.storageUuId = DatanodeStorage.generateUuid();
-    File dataDir = new File(dataLoc.getNormalizedUri().getPath());
+    File dataDir = Paths.get(dataLoc.getNormalizedUri()).resolve(
+        OzoneConsts.CONTAINER_PREFIX).toFile();
+    // Initialize container data root if it does not exist as required by DF/DU
+    if (!dataDir.exists()) {
+      if (!dataDir.mkdirs()) {
+        LOG.error("Unable to create the container storage location at : {}",
+            dataDir);
+        throw new IllegalArgumentException("Unable to create the container" +
+            " storage location at : " + dataDir);
+      }
+    }
     scmUsedFile = new File(dataDir, DU_CACHE_FILE);
     // get overall disk usage
     this.usage = new DF(dataDir, conf);