HDFS-14125. Use parameterized log format in ECTopologyVerifier. Contributed by Kitti Nanasi.

Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
This commit is contained in:
Kitti Nanasi 2019-02-04 14:51:17 -08:00 committed by Wei-Chiu Chuang
parent 0e79a86582
commit 5f15a60e32

View File

@ -93,24 +93,24 @@ private static ECTopologyVerifierResult verifyECWithTopology(
final int numOfRacks, final int numOfDataNodes, String readablePolicies) {
String resultMessage;
if (numOfDataNodes < minDN) {
resultMessage = "The number of DataNodes (" + numOfDataNodes
+ ") is less than the minimum required number of DataNodes ("
+ minDN + ") for the erasure coding policies: " + readablePolicies;
resultMessage = String.format("The number of DataNodes (%d) is less " +
"than the minimum required number of DataNodes (%d) for the " +
"erasure coding policies: %s", numOfDataNodes, minDN,
readablePolicies);
LOG.debug(resultMessage);
return new ECTopologyVerifierResult(false, resultMessage);
}
if (numOfRacks < minRack) {
resultMessage = "The number of racks (" + numOfRacks
+ ") is less than the minimum required number of racks ("
+ minRack + ") for the erasure coding policies: "
+ readablePolicies;
resultMessage = String.format("The number of racks (%d) is less than " +
"the minimum required number of racks (%d) for the erasure " +
"coding policies: %s", numOfRacks, minRack, readablePolicies);
LOG.debug(resultMessage);
return new ECTopologyVerifierResult(false, resultMessage);
}
return new ECTopologyVerifierResult(true,
"The cluster setup can support EC policies: "
+ readablePolicies);
String.format("The cluster setup can support EC policies: %s",
readablePolicies));
}
private static int getNumberOfRacks(DatanodeInfo[] report) {