big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-18612. Avoid mixing canonical and non-canonical when performing comparisons (#5339)

Browse Source 
Contributed by Steve Vaughan Jr
This commit is contained in:
Steve Vaughan 2023-02-06 13:28:29 -05:00 committed by GitHub
parent aed6fcee5b
commit 5f5157ac53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
View File

@ -1321,16 +1321,16 @@ public void testCreateJarWithClassPath() throws Exception {
if (wildcardPath.equals(classPath)) { if (wildcardPath.equals(classPath)) {
// add wildcard matches // add wildcard matches
for (File wildcardMatch: wildcardMatches) { for (File wildcardMatch: wildcardMatches) {
expectedClassPaths.add(wildcardMatch.toURI().toURL() expectedClassPaths.add(wildcardMatch.getCanonicalFile().toURI().toURL()
.toExternalForm()); .toExternalForm());
} }
} else { } else {
File fileCp = null; File fileCp = null;
if(!new Path(classPath).isAbsolute()) { if(!new Path(classPath).isAbsolute()) {
fileCp = new File(tmp, classPath); fileCp = new File(tmp, classPath).getCanonicalFile();
} }
else { else {
fileCp = new File(classPath); fileCp = new File(classPath).getCanonicalFile();
} }
if (nonExistentSubdir.equals(classPath)) { if (nonExistentSubdir.equals(classPath)) {
// expect to maintain trailing path separator if present in input, even // expect to maintain trailing path separator if present in input, even
@ -1385,7 +1385,8 @@ public void testGetJarsInDirectory() throws Exception {
for (Path jar: jars) { for (Path jar: jars) {
URL url = jar.toUri().toURL(); URL url = jar.toUri().toURL();
assertTrue("the jar should match either of the jars", assertTrue("the jar should match either of the jars",
url.equals(jar1.toURI().toURL()) || url.equals(jar2.toURI().toURL())); url.equals(jar1.getCanonicalFile().toURI().toURL()) ||
url.equals(jar2.getCanonicalFile().toURI().toURL()));
} }
} }