big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

YARN-84. Use Builder to build RPC server. Contributed by Brandon Li

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1380921 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Suresh Srinivas 2012-09-04 22:24:04 +00:00
parent f5943c1eef
commit 60af999c73
5 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/security/TestUmbilicalProtocolWithJobToken.java
View File

@ -88,8 +88,10 @@ public void testJobTokenRpc() throws Exception {
.when(mockTT).getProtocolSignature(anyString(), anyLong(), anyInt()); .when(mockTT).getProtocolSignature(anyString(), anyLong(), anyInt());
JobTokenSecretManager sm = new JobTokenSecretManager(); JobTokenSecretManager sm = new JobTokenSecretManager();
final Server server = RPC.getServer(TaskUmbilicalProtocol.class, mockTT, final Server server = new RPC.Builder(conf)
ADDRESS, 0, 5, true, conf, sm); .setProtocol(TaskUmbilicalProtocol.class).setInstance(mockTT)
.setBindAddress(ADDRESS).setPort(0).setNumHandlers(5).setVerbose(true)
.setSecretManager(sm).build();
server.start(); server.start();

2
hadoop-yarn-project/CHANGES.txt
View File

@ -8,6 +8,8 @@ Trunk (unreleased changes)
IMPROVEMENTS IMPROVEMENTS
YARN-84. Use Builder to build RPC server. (Brandon Li via suresh)
OPTIMAZATIONS OPTIMAZATIONS
BUG FIXES BUG FIXES

8
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/factories/impl/pb/RpcServerFactoryPBImpl.java
View File

@ -166,9 +166,11 @@ private Server createServer(Class<?> pbProtocol, InetSocketAddress addr, Configu
SecretManager<? extends TokenIdentifier> secretManager, int numHandlers, SecretManager<? extends TokenIdentifier> secretManager, int numHandlers,
BlockingService blockingService, String portRangeConfig) throws IOException { BlockingService blockingService, String portRangeConfig) throws IOException {
RPC.setProtocolEngine(conf, pbProtocol, ProtobufRpcEngine.class); RPC.setProtocolEngine(conf, pbProtocol, ProtobufRpcEngine.class);
RPC.Server server = RPC.getServer(pbProtocol, blockingService, RPC.Server server = new RPC.Builder(conf).setProtocol(pbProtocol)
addr.getHostName(), addr.getPort(), numHandlers, false, conf, .setInstance(blockingService).setBindAddress(addr.getHostName())
secretManager, portRangeConfig); .setPort(addr.getPort()).setNumHandlers(numHandlers).setVerbose(false)
.setSecretManager(secretManager).setPortRangeConfig(portRangeConfig)
.build();
LOG.info("Adding protocol "+pbProtocol.getCanonicalName()+" to the server"); LOG.info("Adding protocol "+pbProtocol.getCanonicalName()+" to the server");
server.addProtocol(RPC.RpcKind.RPC_PROTOCOL_BUFFER, pbProtocol, blockingService); server.addProtocol(RPC.RpcKind.RPC_PROTOCOL_BUFFER, pbProtocol, blockingService);
return server; return server;

6
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/TestNMAuditLogger.java
View File

@ -204,8 +204,10 @@ public void ping() {
public void testNMAuditLoggerWithIP() throws Exception { public void testNMAuditLoggerWithIP() throws Exception {
Configuration conf = new Configuration(); Configuration conf = new Configuration();
// start the IPC server // start the IPC server
Server server = RPC.getServer(TestProtocol.class, Server server = new RPC.Builder(conf).setProtocol(TestProtocol.class)
new MyTestRPCServer(), "0.0.0.0", 0, 5, true, conf, null); .setInstance(new MyTestRPCServer()).setBindAddress("0.0.0.0")
.setPort(0).setNumHandlers(5).setVerbose(true).build();
server.start(); server.start();
InetSocketAddress addr = NetUtils.getConnectAddress(server); InetSocketAddress addr = NetUtils.getConnectAddress(server);

5
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMAuditLogger.java
View File

@ -222,8 +222,9 @@ public void ping() {
public void testRMAuditLoggerWithIP() throws Exception { public void testRMAuditLoggerWithIP() throws Exception {
Configuration conf = new Configuration(); Configuration conf = new Configuration();
// start the IPC server // start the IPC server
Server server = RPC.getServer(TestProtocol.class, Server server = new RPC.Builder(conf).setProtocol(TestProtocol.class)
new MyTestRPCServer(), "0.0.0.0", 0, 5, true, conf, null); .setInstance(new MyTestRPCServer()).setBindAddress("0.0.0.0")
.setPort(0).setNumHandlers(5).setVerbose(true).build();
server.start(); server.start();
InetSocketAddress addr = NetUtils.getConnectAddress(server); InetSocketAddress addr = NetUtils.getConnectAddress(server);