HDFS-16247. RBF: Fix the ProcessingAvgTime and ProxyAvgTime code comments and document metrics describe ms unit (#3511)

This commit is contained in:
huhaiyang 2021-10-04 23:52:26 +08:00 committed by GitHub
parent 5f0452602f
commit 68c2accc20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions

View File

@ -567,9 +567,9 @@ RouterRPCMetrics shows the statistics of the Router component in Router-based fe
| `RouterFailureLocked` | Number of failed requests due to locked path | | `RouterFailureLocked` | Number of failed requests due to locked path |
| `RouterFailureSafemode` | Number of failed requests due to safe mode | | `RouterFailureSafemode` | Number of failed requests due to safe mode |
| `ProcessingNumOps` | Number of operations the Router processed internally within an interval time of metric | | `ProcessingNumOps` | Number of operations the Router processed internally within an interval time of metric |
| `ProcessingAvgTime` | Average time for the Router to process operations in nanoseconds | | `ProcessingAvgTime` | Average time for the Router to process operations in milliseconds |
| `ProxyNumOps` | Number of times of that the Router to proxy operations to the Namenodes within an interval time of metric | | `ProxyNumOps` | Number of times of that the Router to proxy operations to the Namenodes within an interval time of metric |
| `ProxyAvgTime` | Average time for the Router to proxy operations to the Namenodes in nanoseconds | | `ProxyAvgTime` | Average time for the Router to proxy operations to the Namenodes in milliseconds |
StateStoreMetrics StateStoreMetrics
----------------- -----------------

View File

@ -218,7 +218,7 @@ public void routerFailureLocked() {
/** /**
* Get time between we receiving the operation and sending it to the Namenode. * Get time between we receiving the operation and sending it to the Namenode.
* @return Processing time in nanoseconds. * @return Processing time in milliseconds.
*/ */
private long getProcessingTime() { private long getProcessingTime() {
if (START_TIME.get() != null && START_TIME.get() > 0 && if (START_TIME.get() != null && START_TIME.get() > 0 &&
@ -230,7 +230,7 @@ private long getProcessingTime() {
/** /**
* Get time between now and when the operation was forwarded to the Namenode. * Get time between now and when the operation was forwarded to the Namenode.
* @return Current proxy time in nanoseconds. * @return Current proxy time in milliseconds.
*/ */
private long getProxyTime() { private long getProxyTime() {
if (PROXY_TIME.get() != null && PROXY_TIME.get() > 0) { if (PROXY_TIME.get() != null && PROXY_TIME.get() > 0) {