From 6942fd1db5fe0a8971ac5df65757bbab3d2e06c7 Mon Sep 17 00:00:00 2001 From: Suresh Srinivas Date: Thu, 7 Mar 2013 01:09:53 +0000 Subject: [PATCH] HADOOP-9372. Fix bad timeout annotations on tests. Contributed by Arpit Agarwal. git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1453637 13f79535-47bb-0310-9956-ffa450edef68 --- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../src/test/java/org/apache/hadoop/util/TestWinUtils.java | 3 --- hadoop-mapreduce-project/CHANGES.txt | 3 +++ .../test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java | 4 ++-- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 1a381c980a..b9d2ba1b7c 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -453,6 +453,9 @@ Trunk (Unreleased) HADOOP-9373. Merge CHANGES.branch-trunk-win.txt to CHANGES.txt. (suresh) + HADOOP-9372. Fix bad timeout annotations on tests. + (Arpit Agarwal via suresh) + Release 2.0.4-beta - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestWinUtils.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestWinUtils.java index 29140db3b9..f75fc35062 100644 --- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestWinUtils.java +++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestWinUtils.java @@ -152,7 +152,6 @@ private void assertPermissions(File file, String expected) assertEquals(expected, output); } - @Test (timeout = 30000) private void testChmodInternal(String mode, String expectedPerm) throws IOException { File a = new File(TEST_DIR, "file1"); @@ -171,7 +170,6 @@ private void testChmodInternal(String mode, String expectedPerm) assertFalse(a.exists()); } - @Test (timeout = 30000) private void testNewFileChmodInternal(String expectedPerm) throws IOException { // Create a new directory File dir = new File(TEST_DIR, "dir1"); @@ -193,7 +191,6 @@ private void testNewFileChmodInternal(String expectedPerm) throws IOException { assertFalse(dir.exists()); } - @Test (timeout = 30000) private void testChmodInternalR(String mode, String expectedPerm, String expectedPermx) throws IOException { // Setup test folder hierarchy diff --git a/hadoop-mapreduce-project/CHANGES.txt b/hadoop-mapreduce-project/CHANGES.txt index e2ccf47b45..92b6676a20 100644 --- a/hadoop-mapreduce-project/CHANGES.txt +++ b/hadoop-mapreduce-project/CHANGES.txt @@ -177,6 +177,9 @@ Trunk (Unreleased) MAPREDUCE-4983. Fixed various platform specific assumptions in various tests, so that they can pass on Windows too. (Chris Nauroth via vinodkv) + HADOOP-9372. Fix bad timeout annotations on tests. + (Arpit Agarwal via suresh) + Release 2.0.4-beta - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java index 348f3794ef..698b67b6cc 100644 --- a/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java +++ b/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRJobs.java @@ -144,7 +144,7 @@ public static void tearDown() { } } - @Test (timeout = 30000) + @Test (timeout = 300000) public void testSleepJob() throws IOException, InterruptedException, ClassNotFoundException { LOG.info("\n\n\nStarting testSleepJob()."); @@ -542,7 +542,7 @@ public void _testDistributedCache(String jobJarPath) throws Exception { trackingUrl.endsWith(jobId.substring(jobId.lastIndexOf("_")) + "/")); } - @Test (timeout = 30000) + @Test (timeout = 300000) public void testDistributedCache() throws Exception { // Test with a local (file:///) Job Jar Path localJobJarPath = makeJobJarWithLib(TEST_ROOT_DIR.toUri().toString());