big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HADOOP-17841. Remove ListenerHandle from Hadoop registry (#3278)

Browse Source
This commit is contained in:
Viraj Jasani 2021-08-09 14:27:53 +05:30 committed by GitHub
parent 0c7b951e03
commit 6a7883431f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hadoop-common-project/hadoop-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java
View File

@ -824,9 +824,8 @@ protected String dumpRegistryRobustly(boolean verbose) {
* Registers a listener to path related events. * Registers a listener to path related events.
* *
* @param listener the listener. * @param listener the listener.
* @return a handle allowing for the management of the listener.
*/ */
public ListenerHandle registerPathListener(final PathListener listener) { public void registerPathListener(final PathListener listener) {
CuratorCacheListener cacheListener = CuratorCacheListener.builder() CuratorCacheListener cacheListener = CuratorCacheListener.builder()
.forCreatesAndChanges((oldNode, node) -> { .forCreatesAndChanges((oldNode, node) -> {
@ -854,7 +853,6 @@ public ListenerHandle registerPathListener(final PathListener listener) {
.build(); .build();
curatorCacheBridge.listenable().addListener(cacheListener); curatorCacheBridge.listenable().addListener(cacheListener);
return () -> curatorCacheBridge.listenable().removeListener(cacheListener);
} }
// TODO: should caches be stopped and then restarted if need be? // TODO: should caches be stopped and then restarted if need be?

25
hadoop-common-project/hadoop-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/ListenerHandle.java
View File

@ -1,25 +0,0 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.hadoop.registry.client.impl.zk;
/**
*
*/
public interface ListenerHandle {
void remove();
}