diff --git a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt index 5fbbb9d1a6..69b1a8be63 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt +++ b/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt @@ -378,6 +378,9 @@ Release 2.4.1 - UNRELEASED HDFS-6234. TestDatanodeConfig#testMemlockLimit fails on Windows due to invalid file path. (cnauroth) + HDFS-6235. TestFileJournalManager can fail on Windows due to file locking if + tests run out of order. (cnauroth) + Release 2.4.0 - 2014-04-07 INCOMPATIBLE CHANGES diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java index a5dbc47ffa..c7fe67f016 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFileJournalManager.java @@ -139,7 +139,7 @@ public void testNormalOperation() throws IOException { */ @Test public void testInprogressRecovery() throws IOException { - File f = new File(TestEditLog.TEST_DIR + "/filejournaltest0"); + File f = new File(TestEditLog.TEST_DIR + "/inprogressrecovery"); // abort after the 5th roll NNStorage storage = setupEdits(Collections.singletonList(f.toURI()), 5, new AbortSpec(5, 0)); @@ -255,7 +255,7 @@ public void testFinalizeErrorReportedToNNStorage() throws IOException, Interrupt */ @Test public void testReadFromStream() throws IOException { - File f = new File(TestEditLog.TEST_DIR + "/filejournaltest1"); + File f = new File(TestEditLog.TEST_DIR + "/readfromstream"); // abort after 10th roll NNStorage storage = setupEdits(Collections.singletonList(f.toURI()), 10, new AbortSpec(10, 0)); @@ -282,7 +282,7 @@ public void testReadFromStream() throws IOException { */ @Test public void testAskForTransactionsMidfile() throws IOException { - File f = new File(TestEditLog.TEST_DIR + "/filejournaltest2"); + File f = new File(TestEditLog.TEST_DIR + "/askfortransactionsmidfile"); NNStorage storage = setupEdits(Collections.singletonList(f.toURI()), 10); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); @@ -307,7 +307,7 @@ public void testAskForTransactionsMidfile() throws IOException { */ @Test public void testManyLogsWithGaps() throws IOException { - File f = new File(TestEditLog.TEST_DIR + "/filejournaltest3"); + File f = new File(TestEditLog.TEST_DIR + "/manylogswithgaps"); NNStorage storage = setupEdits(Collections.singletonList(f.toURI()), 10); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); @@ -341,7 +341,7 @@ public boolean accept(File dir, String name) { */ @Test public void testManyLogsWithCorruptInprogress() throws IOException { - File f = new File(TestEditLog.TEST_DIR + "/filejournaltest5"); + File f = new File(TestEditLog.TEST_DIR + "/manylogswithcorruptinprogress"); NNStorage storage = setupEdits(Collections.singletonList(f.toURI()), 10, new AbortSpec(10, 0)); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); @@ -426,7 +426,7 @@ private static EditLogInputStream getJournalInputStream(JournalManager jm, @Test public void testReadFromMiddleOfEditLog() throws CorruptionException, IOException { - File f = new File(TestEditLog.TEST_DIR + "/filejournaltest2"); + File f = new File(TestEditLog.TEST_DIR + "/readfrommiddleofeditlog"); NNStorage storage = setupEdits(Collections.singletonList(f.toURI()), 10); StorageDirectory sd = storage.dirIterator(NameNodeDirType.EDITS).next(); @@ -449,7 +449,7 @@ public void testReadFromMiddleOfEditLog() throws CorruptionException, @Test public void testExcludeInProgressStreams() throws CorruptionException, IOException { - File f = new File(TestEditLog.TEST_DIR + "/filejournaltest2"); + File f = new File(TestEditLog.TEST_DIR + "/excludeinprogressstreams"); // Don't close the edit log once the files have been set up. NNStorage storage = setupEdits(Collections.singletonList(f.toURI()),