YARN-9036. Escape newlines in health report in YARN UI. Contributed by Keqiu Hu

This commit is contained in:
Jonathan Hung 2018-11-29 17:02:07 -08:00 committed by Jonathan Hung
parent 38ea3814bd
commit 6d7b44c489

View File

@ -19,6 +19,7 @@
package org.apache.hadoop.yarn.server.resourcemanager.webapp; package org.apache.hadoop.yarn.server.resourcemanager.webapp;
import com.google.inject.Inject; import com.google.inject.Inject;
import org.apache.commons.text.StringEscapeUtils;
import org.apache.hadoop.util.StringUtils; import org.apache.hadoop.util.StringUtils;
import org.apache.hadoop.yarn.api.records.NodeState; import org.apache.hadoop.yarn.api.records.NodeState;
import org.apache.hadoop.yarn.conf.YarnConfiguration; import org.apache.hadoop.yarn.conf.YarnConfiguration;
@ -203,8 +204,9 @@ protected void render(Block html) {
nodeTableData.length() - 1); nodeTableData.length() - 1);
} }
nodeTableData.append("]"); nodeTableData.append("]");
String nodeTableDataEscaped = StringEscapeUtils.escapeJava(nodeTableData.toString());
html.script().$type("text/javascript") html.script().$type("text/javascript")
.__("var nodeTableData=" + nodeTableData).__(); .__("var nodeTableData=" + nodeTableDataEscaped).__();
tbody.__().__(); tbody.__().__();
} }
} }