big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-15623. Respect configured values of rpc.engine (#2403) Contributed by Hector Chaverri.

Browse Source
This commit is contained in:
hchaverr 2020-10-22 10:32:28 -07:00 committed by Konstantin V Shvachko
parent 4b312810ae
commit 6eacaffeea
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
View File

@ -195,14 +195,18 @@ private RPC() {} // no public ctor
private static final String ENGINE_PROP = "rpc.engine"; private static final String ENGINE_PROP = "rpc.engine";
/** /**
* Set a protocol to use a non-default RpcEngine. * Set a protocol to use a non-default RpcEngine if one
* is not specified in the configuration.
* @param conf configuration to use * @param conf configuration to use
* @param protocol the protocol interface * @param protocol the protocol interface
* @param engine the RpcEngine impl * @param engine the RpcEngine impl
*/ */
public static void setProtocolEngine(Configuration conf, public static void setProtocolEngine(Configuration conf,
Class<?> protocol, Class<?> engine) { Class<?> protocol, Class<?> engine) {
conf.setClass(ENGINE_PROP+"."+protocol.getName(), engine, RpcEngine.class); if (conf.get(ENGINE_PROP+"."+protocol.getName()) == null) {
conf.setClass(ENGINE_PROP+"."+protocol.getName(), engine,
RpcEngine.class);
}
} }
// return the RpcEngine configured to handle a protocol // return the RpcEngine configured to handle a protocol

12
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
View File

@ -1554,6 +1554,18 @@ public RpcStatusProto getRpcStatusProto() {
} }
} }
@Test
public void testSetProtocolEngine() {
Configuration conf = new Configuration();
RPC.setProtocolEngine(conf, StoppedProtocol.class, StoppedRpcEngine.class);
RpcEngine rpcEngine = RPC.getProtocolEngine(StoppedProtocol.class, conf);
assertTrue(rpcEngine instanceof StoppedRpcEngine);
RPC.setProtocolEngine(conf, StoppedProtocol.class, ProtobufRpcEngine.class);
rpcEngine = RPC.getProtocolEngine(StoppedProtocol.class, conf);
assertTrue(rpcEngine instanceof StoppedRpcEngine);
}
public static void main(String[] args) throws Exception { public static void main(String[] args) throws Exception {
new TestRPC().testCallsInternal(conf); new TestRPC().testCallsInternal(conf);
} }