diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index 84e7076a81..098194ced3 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -1023,6 +1023,9 @@ Release 2.8.0 - UNRELEASED HADOOP-12175. FsShell must load SpanReceierHost to support tracing (Masatake Iwasaki via Colin P. McCabe) + HADOOP-10945. 4-digit octal umask permissions throws a parse error (Chang + Li via jlowe) + Release 2.7.2 - UNRELEASED INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/UmaskParser.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/UmaskParser.java index 79956c593c..0cf26c51a7 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/UmaskParser.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/UmaskParser.java @@ -33,7 +33,7 @@ @InterfaceStability.Unstable class UmaskParser extends PermissionParser { private static Pattern chmodOctalPattern = - Pattern.compile("^\\s*[+]?()([0-7]{3})\\s*$"); // no leading 1 for sticky bit + Pattern.compile("^\\s*[+]?(0*)([0-7]{3})\\s*$"); // no leading 1 for sticky bit private static Pattern umaskSymbolicPattern = /* not allow X or t */ Pattern.compile("\\G\\s*([ugoa]*)([+=-]+)([rwx]*)([,\\s]*)\\s*"); final short umaskMode; diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java index 036aaaea71..425c82ecb7 100644 --- a/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java +++ b/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java @@ -20,6 +20,7 @@ import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; +import static org.junit.Assert.fail; import java.io.IOException; import java.util.Random; @@ -100,6 +101,31 @@ public void testBackwardCompatibility() { conf = new Configuration(); conf.set(FsPermission.UMASK_LABEL, "022"); assertEquals(18, FsPermission.getUMask(conf).toShort()); + + // Test 5 - equivalent valid umask + conf = new Configuration(); + conf.set(FsPermission.UMASK_LABEL, "0022"); + assertEquals(18, FsPermission.getUMask(conf).toShort()); + + // Test 6 - invalid umask + conf = new Configuration(); + conf.set(FsPermission.UMASK_LABEL, "1222"); + try { + FsPermission.getUMask(conf); + fail("expect IllegalArgumentException happen"); + } catch (IllegalArgumentException e) { + //pass, exception successfully trigger + } + + // Test 7 - invalid umask + conf = new Configuration(); + conf.set(FsPermission.UMASK_LABEL, "01222"); + try { + FsPermission.getUMask(conf); + fail("expect IllegalArgumentException happen"); + } catch (IllegalArgumentException e) { + //pass, exception successfully trigger + } } @Test