big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-2054 BlockSender.sendChunk() prints ERROR for connection closures encountered during transferToFully()

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1145751 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael Stack 2011-07-12 20:23:39 +00:00
parent fd5a762df0
commit 714edd65ac
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hdfs/CHANGES.txt
View File

@ -546,6 +546,9 @@ Trunk (unreleased changes)
HDFS-2134. Move DecommissionManager to the blockmanagement package. HDFS-2134. Move DecommissionManager to the blockmanagement package.
(szetszwo) (szetszwo)
HDFS-2054 BlockSender.sendChunk() prints ERROR for connection closures
encountered during transferToFully() (Kihwal Lee via stack)
OPTIMIZATIONS OPTIMIZATIONS
HDFS-1458. Improve checkpoint performance by avoiding unnecessary image HDFS-1458. Improve checkpoint performance by avoiding unnecessary image

15
hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java
View File

@ -401,10 +401,19 @@ private int sendChunks(ByteBuffer pkt, int maxChunks, OutputStream out)
} }
} catch (IOException e) { } catch (IOException e) {
/* exception while writing to the client (well, with transferTo(), /* Exception while writing to the client. Connection closure from
* it could also be while reading from the local file). * the other end is mostly the case and we do not care much about
* it. But other things can go wrong, especially in transferTo(),
* which we do not want to ignore.
*
* The message parsing below should not be considered as a good
* coding example. NEVER do it to drive a program logic. NEVER.
* It was done here because the NIO throws an IOException for EPIPE.
*/ */
LOG.error("BlockSender.sendChunks() exception: " + StringUtils.stringifyException(e)); String ioem = e.getMessage();
if (!ioem.startsWith("Broken pipe") && !ioem.startsWith("Connection reset")) {
LOG.error("BlockSender.sendChunks() exception: ", e);
}
throw ioeToSocketException(e); throw ioeToSocketException(e);
} }