From 774c1f199e11d886d0c0a1069325f0284da35deb Mon Sep 17 00:00:00 2001 From: Xiao Chen Date: Tue, 5 Jun 2018 21:24:25 -0700 Subject: [PATCH] HDFS-13511. Provide specialized exception when block length cannot be obtained. Contributed by Gabor Bota. --- .../CannotObtainBlockLengthException.java | 55 +++++++++++++++++++ .../apache/hadoop/hdfs/DFSInputStream.java | 2 +- 2 files changed, 56 insertions(+), 1 deletion(-) create mode 100644 hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/CannotObtainBlockLengthException.java diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/CannotObtainBlockLengthException.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/CannotObtainBlockLengthException.java new file mode 100644 index 0000000000..6da1d67b9a --- /dev/null +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/CannotObtainBlockLengthException.java @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hdfs; + +import org.apache.hadoop.classification.InterfaceAudience; +import org.apache.hadoop.classification.InterfaceStability; +import org.apache.hadoop.hdfs.protocol.LocatedBlock; + +import java.io.IOException; + +/** + * This exception is thrown when the length of a LocatedBlock instance + * can not be obtained. + */ +@InterfaceAudience.Public +@InterfaceStability.Unstable +public class CannotObtainBlockLengthException extends IOException { + private static final long serialVersionUID = 1L; + + public CannotObtainBlockLengthException() { + super(); + } + + public CannotObtainBlockLengthException(String message){ + super(message); + } + + /** + * Constructs an {@code CannotObtainBlockLengthException} with the + * specified LocatedBlock that failed to obtain block length. + * + * @param locatedBlock + * The LocatedBlock instance which block length can not be obtained + */ + public CannotObtainBlockLengthException(LocatedBlock locatedBlock) { + super("Cannot obtain block length for " + locatedBlock); + } + +} diff --git a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java index 4d70fee035..573b860fab 100644 --- a/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java +++ b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSInputStream.java @@ -360,7 +360,7 @@ private long readBlockLength(LocatedBlock locatedblock) throws IOException { return 0; } - throw new IOException("Cannot obtain block length for " + locatedblock); + throw new CannotObtainBlockLengthException(locatedblock); } public long getFileLength() {