big-data/hadoop
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

HDFS-17451. RBF: fix spotbugs for redundant nullcheck of dns. (#6697)

Browse Source
This commit is contained in:
Jian Zhang 2024-04-23 19:11:51 +08:00 committed by GitHub
parent 6404692c09
commit 782c501441
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java
View File

@ -1089,13 +1089,7 @@ public DatanodeInfo[] getDatanodeReport(DatanodeReportType type)
DatanodeInfo[] getCachedDatanodeReport(DatanodeReportType type) DatanodeInfo[] getCachedDatanodeReport(DatanodeReportType type)
throws IOException { throws IOException {
try { try {
DatanodeInfo[] dns = this.dnCache.get(type); return this.dnCache.get(type);
if (dns == null) {
LOG.debug("Get null DN report from cache");
dns = getCachedDatanodeReportImpl(type);
this.dnCache.put(type, dns);
}
return dns;
} catch (ExecutionException e) { } catch (ExecutionException e) {
LOG.error("Cannot get the DN report for {}", type, e); LOG.error("Cannot get the DN report for {}", type, e);
Throwable cause = e.getCause(); Throwable cause = e.getCause();