From 792eff9ea70da2c6e0ff5a1b177a51e7b2fb96eb Mon Sep 17 00:00:00 2001 From: Steve Loughran Date: Tue, 5 Sep 2017 14:16:57 +0100 Subject: [PATCH] HADOOP-14820 Wasb mkdirs security checks inconsistent with HDFS. Contributed by Sivaguru Sankaridurg --- .../fs/azure/NativeAzureFileSystem.java | 9 ++- ...estNativeAzureFileSystemAuthorization.java | 64 +++++++++++++++++++ .../TestAzureFileSystemInstrumentation.java | 18 ++---- 3 files changed, 77 insertions(+), 14 deletions(-) diff --git a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java index 2abc6c6e80..0bde124a89 100644 --- a/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java +++ b/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/NativeAzureFileSystem.java @@ -2425,13 +2425,13 @@ PermissionStatus createPermissionStatus(FsPermission permission) private Path getAncestor(Path f) throws IOException { - for (Path current = f.getParent(), parent = current.getParent(); + for (Path current = f, parent = current.getParent(); parent != null; // Stop when you get to the root current = parent, parent = current.getParent()) { String currentKey = pathToKey(current); FileMetadata currentMetadata = store.retrieveMetadata(currentKey); - if (currentMetadata != null) { + if (currentMetadata != null && currentMetadata.isDir()) { Path ancestor = keyToPath(currentMetadata.getKey()); LOG.debug("Found ancestor {}, for path: {}", ancestor.toString(), f.toString()); return ancestor; @@ -2448,7 +2448,6 @@ public boolean mkdirs(Path f, FsPermission permission) throws IOException { public boolean mkdirs(Path f, FsPermission permission, boolean noUmask) throws IOException { - LOG.debug("Creating directory: {}", f.toString()); if (containsColon(f)) { @@ -2459,6 +2458,10 @@ public boolean mkdirs(Path f, FsPermission permission, boolean noUmask) throws I Path absolutePath = makeAbsolute(f); Path ancestor = getAncestor(absolutePath); + if (absolutePath.equals(ancestor)) { + return true; + } + performAuthCheck(ancestor, WasbAuthorizationOperations.WRITE, "mkdirs", absolutePath); PermissionStatus permissionStatus = null; diff --git a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java index 91d6ebb90b..a3f28432b8 100644 --- a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java +++ b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/TestNativeAzureFileSystemAuthorization.java @@ -603,6 +603,70 @@ public void testMkdirsCheckPositive() throws Throwable { } } + /** + * Positive test for mkdirs -p with existing hierarchy + * @throws Throwable + */ + @Test + public void testMkdirsWithExistingHierarchyCheckPositive1() throws Throwable { + + Path testPath = new Path("/testMkdirsWithExistingHierarchyCheckPositive1"); + + authorizer.addAuthRule("/", WasbAuthorizationOperations.WRITE.toString(), true); + fs.updateWasbAuthorizer(authorizer); + + try { + fs.mkdirs(testPath); + ContractTestUtils.assertIsDirectory(fs, testPath); + + /* Don't need permissions to create a directory that already exists */ + authorizer.deleteAllAuthRules(); + + fs.mkdirs(testPath); + ContractTestUtils.assertIsDirectory(fs, testPath); + } + finally { + allowRecursiveDelete(fs, testPath.toString()); + fs.delete(testPath, true); + } + } + + @Test + public void testMkdirsWithExistingHierarchyCheckPositive2() throws Throwable { + + Path testPath = new Path("/testMkdirsWithExistingHierarchyCheckPositive2"); + Path childPath1 = new Path(testPath, "1"); + Path childPath2 = new Path(childPath1, "2"); + Path childPath3 = new Path(childPath2, "3"); + + authorizer.addAuthRule("/", + WasbAuthorizationOperations.WRITE.toString(), true); + + authorizer.addAuthRule(childPath1.toString(), + WasbAuthorizationOperations.WRITE.toString(), true); + + fs.updateWasbAuthorizer(authorizer); + + try { + fs.mkdirs(childPath1); + ContractTestUtils.assertIsDirectory(fs, childPath1); + + // Path already exists => no-op. + fs.mkdirs(testPath); + ContractTestUtils.assertIsDirectory(fs, testPath); + + // Path already exists => no-op. + fs.mkdirs(childPath1); + ContractTestUtils.assertIsDirectory(fs, childPath1); + + // Check permissions against existing ancestor childPath1 + fs.mkdirs(childPath3); + ContractTestUtils.assertIsDirectory(fs, childPath3); + } finally { + allowRecursiveDelete(fs, testPath.toString()); + fs.delete(testPath, true); + } + } /** * Negative test for mkdirs access check * @throws Throwable diff --git a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java index a1a021b16e..818a844dfd 100644 --- a/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java +++ b/hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azure/metrics/TestAzureFileSystemInstrumentation.java @@ -108,17 +108,13 @@ public void testMetricsOnMkdirList() throws Exception { // Create a directory assertTrue(fs.mkdirs(new Path("a"))); - // At the time of writing, it takes 1 request to create the actual directory, - // plus 2 requests per level to check that there's no blob with that name and - // 1 request per level above to create it if it doesn't exist. - // So for the path above (/user//a), it takes 2 requests each to check - // there's no blob called /user, no blob called /user/ and no blob - // called /user//a, and then 3 request for the creation of the three - // levels, and then 2 requests for checking/stamping the version of AS, - // totaling 11. - // Also, there's the initial 1 request for container check so total is 12. - // The getAncestor call at the very beginning adds another 4 calls, totalling 16. - base = assertWebResponsesInRange(base, 1, 16); + // At the time of writing + // getAncestor uses 2 calls for each folder level /user//a + // plus 1 call made by checkContainer + // mkdir checks the hierarchy with 2 calls per level + // mkdirs calls storeEmptyDir to create the empty folder, which makes 5 calls + // For a total of 7 + 6 + 5 = 18 web responses + base = assertWebResponsesInRange(base, 1, 18); assertEquals(1, AzureMetricsTestUtil.getLongCounterValue(getInstrumentation(), WASB_DIRECTORIES_CREATED));