From 7fbf69bf47bb733f95b4afd733f9b65e1e7f2b46 Mon Sep 17 00:00:00 2001 From: Akira Ajisaka Date: Thu, 8 Oct 2015 06:08:28 +0900 Subject: [PATCH] HADOOP-12465. Incorrect javadoc in WritableUtils.java. Contributed by Jagadesh Kiran N. --- hadoop-common-project/hadoop-common/CHANGES.txt | 3 +++ .../src/main/java/org/apache/hadoop/io/WritableUtils.java | 8 ++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt index fd6e2f1395..3eb106f599 100644 --- a/hadoop-common-project/hadoop-common/CHANGES.txt +++ b/hadoop-common-project/hadoop-common/CHANGES.txt @@ -1312,6 +1312,9 @@ Release 2.7.2 - UNRELEASED HADOOP-12213. Interrupted exception can occur when Client#stop is called. (Kuhu Shukla via ozawa) + HADOOP-12465. Incorrect javadoc in WritableUtils.java. + (Jagadesh Kiran N via aajisaka) + Release 2.7.1 - 2015-07-06 INCOMPATIBLE CHANGES diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java index ae615dde6f..e58e0e1c3f 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableUtils.java @@ -236,13 +236,13 @@ public static void cloneInto(Writable dst, Writable src) throws IOException { /** * Serializes an integer to a binary stream with zero-compressed encoding. - * For -120 <= i <= 127, only one byte is used with the actual value. + * For -112 <= i <= 127, only one byte is used with the actual value. * For other values of i, the first byte value indicates whether the * integer is positive or negative, and the number of bytes that follow. + * If the first byte value v is between -113 and -116, the following integer + * is positive, with number of bytes that follow are -(v+112). * If the first byte value v is between -121 and -124, the following integer - * is positive, with number of bytes that follow are -(v+120). - * If the first byte value v is between -125 and -128, the following integer - * is negative, with number of bytes that follow are -(v+124). Bytes are + * is negative, with number of bytes that follow are -(v+120). Bytes are * stored in the high-non-zero-byte-first order. * * @param stream Binary output stream