From 840d02ca5ba013bddd28d7c1abd242b5bb8cc39f Mon Sep 17 00:00:00 2001 From: Wei-Chiu Chuang Date: Thu, 20 Jun 2019 19:57:09 -0700 Subject: [PATCH] HADOOP-14385. HttpExceptionUtils#validateResponse swallows exceptions. Contributed by Wei-Chiu Chuang. Signed-off-by: Wei-Chiu Chuang --- .../org/apache/hadoop/util/HttpExceptionUtils.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java index 366c8c787f..12d1ef0120 100644 --- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java +++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/HttpExceptionUtils.java @@ -154,18 +154,20 @@ public static void validateResponse(HttpURLConnection conn, toThrow = (Exception) constr.newInstance(exMsg); } catch (Exception ex) { toThrow = new IOException(String.format( - "HTTP status [%d], exception [%s], message [%s] ", - conn.getResponseCode(), exClass, exMsg)); + "HTTP status [%d], exception [%s], message [%s], URL [%s]", + conn.getResponseCode(), exClass, exMsg, conn.getURL())); } } else { String msg = (exMsg != null) ? exMsg : conn.getResponseMessage(); toThrow = new IOException(String.format( - "HTTP status [%d], message [%s]", conn.getResponseCode(), msg)); + "HTTP status [%d], message [%s], URL [%s]", + conn.getResponseCode(), msg, conn.getURL())); } } catch (Exception ex) { toThrow = new IOException(String.format( - "HTTP status [%d], message [%s]", conn.getResponseCode(), - conn.getResponseMessage())); + "HTTP status [%d], message [%s], URL [%s], exception [%s]", + conn.getResponseCode(), conn.getResponseMessage(), conn.getURL(), + ex.toString()), ex); } finally { if (es != null) { try {